Bugzilla – Attachment 109067 Details for
Bug 16357
Plack error logs are not time stamped
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16357: (QA follow-up) Only initialize Log4perl module
Bug-16357-QA-follow-up-Only-initialize-Log4perl-mo.patch (text/plain), 1.12 KB, created by
Joonas Kylmälä
on 2020-08-25 12:27:25 UTC
(
hide
)
Description:
Bug 16357: (QA follow-up) Only initialize Log4perl module
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2020-08-25 12:27:25 UTC
Size:
1.12 KB
patch
obsolete
>From 060d09663123c0ee281cd371c0385bc7664295da Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Tue, 25 Aug 2020 12:10:20 +0000 >Subject: [PATCH] Bug 16357: (QA follow-up) Only initialize Log4perl module > >Koha::Logger->get was setting up some extra variables >which are not used nor needed for the Plack::Middleware::Log4perl >middleware to work. According to documentation at >https://metacpan.org/pod/Plack::Middleware::Log4perl#SYNOPSIS >only running Log::Log4perl::init, enabling Log4Perl middleware and >setting up the logging category is enough. Koha::Logger->_init runs the >Log::Log4perl::init and enabling and setting category is handled >directly in plack.psgi. >--- > debian/templates/plack.psgi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/debian/templates/plack.psgi b/debian/templates/plack.psgi >index 32d17940ae..7bfb34fb68 100644 >--- a/debian/templates/plack.psgi >+++ b/debian/templates/plack.psgi >@@ -66,7 +66,7 @@ my $apiv1 = builder { > $server->to_psgi_app; > }; > >-Koha::Logger->get; >+Koha::Logger->_init; > > builder { > enable "ReverseProxy"; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16357
:
71752
|
71753
|
71871
|
72290
|
72296
|
73404
|
77529
|
77530
|
77531
|
77532
|
77533
|
106141
|
106313
|
106319
|
106320
|
109053
|
109054
|
109055
|
109056
|
109060
|
109067
|
109068
|
109133
|
109215
|
110107
|
110108
|
110109
|
110249
|
110250
|
110251
|
110252
|
110253
|
110254