Attachment 109069 Details for Bug 11299 – Bug 11299: (follow-up) Skip fields with no 9 subfields

[patch] Bug 11299: (follow-up) Skip fields with no 9 subfields

Bug-11299-follow-up-Skip-fields-with-no-9-subfield.patch (text/plain), 1.30 KB, created by Nick Clemens (kidclamp) on 2020-08-25 12:28:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-08-25 12:28:36 UTC

Size: 1.30 KB

patch

obsolete

>From 20005c0f659d6f55a31909b56a3bcae8480a1bbb Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 25 Aug 2020 11:26:31 +0000
>Subject: [PATCH] Bug 11299: (follow-up) Skip fields with no 9 subfields
>
>To test:
>1 - Disable the 'thesaurus' for a controlled field like 600a or 650a
>2 - Edit a record and put random data in this field
>3 - Try to link, get a JS error
>4 - Apply patch
>5 - Repeat
>6 - No more error, field is not linked (as it has no $9 subfield)
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 5803d195ac..0c46521883 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -265,6 +265,8 @@ function updateHeadingLinks(links) {
> 
>         // Find the $9 field to update
>         var tag_subfield_line = $('.subfield_line[id^=subfield' + heading.tag + '9]').eq(tag_index);
>+        if( typeof tag_subfield_line === 'undefined' ){ return; }
>+
>         var subfield = tag_subfield_line.children('.input_marceditor').eq(0);
> 
>         // Delete the old status if one exists
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 11299: 23146 | 26715 | 33074 | 37912 | 37913 | 37972 | 38737 | 39477 | 39478 | 39479 | 40831 | 41229 | 45218 | 56440 | 56508 | 56509 | 58307 | 60998 | 63311 | 63312 | 63313 | 64075 | 67162 | 67708 | 67709 | 67710 | 67712 | 67713 | 67714 | 67824 | 67825 | 67826 | 67827 | 67828 | 67829 | 79385 | 79386 | 79387 | 79388 | 79389 | 79390 | 79391 | 79392 | 79393 | 79394 | 79395 | 79396 | 79397 | 79398 | 79399 | 79447 | 79448 | 79449 | 79450 | 79451 | 79452 | 79545 | 94818 | 95126 | 95152 | 98571 | 98572 | 99249 | 108091 | 108309 | 108310 | 108396 | 108552 | 108834 | 108835 | 109062 | 109063 | 109069 | 109181 | 110553 | 110554 | 110555 | 110556 | 110557 | 110568 | 110569 | 110570 | 110571 | 110572 | 111706 | 111707 | 111708 | 111709 | 111710 | 112125 | 112126 | 112127 | 112128 | 112129 | 112130 | 112131 | 112132 | 112133 | 112134 | 112135 | 113562 | 113563 | 113564 | 113565 | 113566 | 113567 | 113568 | 114803 | 114924 | 114925 | 114926 | 114927 | 114928 | 114929 | 114930 | 114931 | 114932