Bugzilla – Attachment 109131 Details for
Bug 19889
LocalHoldsPriority needs exclusions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19889: (QA follow-up) Check that exclude from local holds priority is set and not a blank string
Bug-19889-QA-follow-up-Check-that-exclude-from-loc.patch (text/plain), 1.24 KB, created by
Agustín Moyano
on 2020-08-25 20:15:49 UTC
(
hide
)
Description:
Bug 19889: (QA follow-up) Check that exclude from local holds priority is set and not a blank string
Filename:
MIME Type:
Creator:
Agustín Moyano
Created:
2020-08-25 20:15:49 UTC
Size:
1.24 KB
patch
obsolete
>From 115e6bab8bcb6f4f7aacf1527deaff7ce865544a Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 20 Aug 2020 10:36:23 +0000 >Subject: [PATCH] Bug 19889: (QA follow-up) Check that exclude from local holds > priority is set and not a blank string > >Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> >--- > tools/batchMod.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index bcf509d537..83a052b318 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -241,7 +241,7 @@ if ($op eq "action") { > } > else { > my $modified_holds_priority = 0; >- if (defined $exclude_from_local_holds_priority) { >+ if ( defined $exclude_from_local_holds_priority && $exclude_from_local_holds_priority ne "" ) { > if(!defined $item->exclude_from_local_holds_priority || $item->exclude_from_local_holds_priority != $exclude_from_local_holds_priority) { > $item->exclude_from_local_holds_priority($exclude_from_local_holds_priority)->store; > $modified_holds_priority = 1; >-- >2.25.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19889
:
105715
|
105716
|
105717
|
105718
|
106435
|
106436
|
106437
|
106438
|
106439
|
106440
|
106441
|
106442
|
107180
|
107187
|
107188
|
107189
|
107190
|
107191
|
107192
|
107193
|
107194
|
107195
|
107196
|
107908
|
107909
|
107910
|
107911
|
107912
|
107913
|
107926
|
107927
|
107928
|
107929
|
107930
|
107931
|
107948
|
108213
|
108214
|
108215
|
108216
|
108217
|
108218
|
108219
|
108220
|
108593
|
108594
|
108595
|
108725
|
108726
|
108728
| 109131 |
109132
|
109285
|
109364
|
109419