Attachment 109135 Details for Bug 26285 – Bug 26285: Follow E.164 pattern for OPAC too

[patch] Bug 26285: Follow E.164 pattern for OPAC too

Bug-26285-Follow-E164-pattern-for-OPAC-too.patch (text/plain), 1.80 KB, created by David Cook on 2020-08-26 04:07:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2020-08-26 04:07:13 UTC

Size: 1.80 KB

patch

obsolete

>From 823c359844ceb3ec0ca628b3f726be2d4d33bdbc Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 26 Aug 2020 04:05:21 +0000
>Subject: [PATCH] Bug 26285: Follow E.164 pattern for OPAC too
>
>This patch uses the E.164 pattern for phone numbers
>for the OPAC (and not just the staff interface).
>
>To test:
>0) Follow the same plan as the staff interface, but
>go to /cgi-bin/koha/opac-messaging.pl after logging
>into the OPAC
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 4367c513f1..2563d61be9 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -132,7 +132,7 @@
>                             [% IF ( SMSSendDriver ) %]
>                                 <ol><li><label>Notice:</label>Some charges for text messages may be incurred when using this service. Please check with your mobile service provider if you have questions.</li></ol>
>                                 <ol><li>
>-                                    <label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^\+?[1-9]\d{1,14}$" />
>+                                    <label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^(\+[1-9]\d{0,2})?\d{1,12}$" />
>                                     <em>Please enter numbers only. <strong>(123) 456-7890</strong> would be entered as <strong>1234567890</strong>.</em>
>                                 </li></ol>
>                             [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26285: 108964 | 108979 | 109034 | 109135 | 109542 | 109543