Attachment 109191 Details for Bug 26299 – Bug 26299: Use same SMS number help text in OPAC as staff interface

[patch] Bug 26299: Use same SMS number help text in OPAC as staff interface

Bug-26299-Use-same-SMS-number-help-text-in-OPAC-as.patch (text/plain), 2.19 KB, created by Katrin Fischer on 2020-08-26 18:51:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-08-26 18:51:51 UTC

Size: 2.19 KB

patch

obsolete

>From 7c8791a3710a6eff6e19ea1e723df8f5cdad907e Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 26 Aug 2020 04:09:29 +0000
>Subject: [PATCH] Bug 26299: Use same SMS number help text in OPAC as staff
> interface
>
>The SMS number help text in the OPAC follows a North American phone
>number style. It should be more generic. To that end, this patch
>makes the OPAC use the same help text for SMS numbers as
>the staff interface
>
>To test:
>1) Apply the patch
>2) Set "SMSSendDriver" to "Anything" in global system preferences
>3) Go to the following link and note the help text by SMS number
>http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51
>4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl
>5) Note that the help text in both interfaces uses the same wording
>
>Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 4367c513f1..8fb5a6837a 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -133,7 +133,7 @@
> <ol><li><label>Notice:</label>Some charges for text messages may be incurred when using this service. Please check with your mobile service provider if you have questions.</li></ol>
> <ol><li>
> <label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^\+?[1-9]\d{1,14}$" />
>- Please enter numbers only. (123) 456-7890 would be entered as 1234567890.
>+ SMS number should be in the format 1234567890 or +11234567890.
> </li></ol>
> [% END %]
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26299: 109136 | 109183 | 109191 | 109625 | 109667 | 109991