Bugzilla – Attachment 109205 Details for
Bug 22789
Establish non-priority holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22789: (QA follow-up) Some minor formatting changes
Bug-22789-QA-follow-up-Some-minor-formatting-chang.patch (text/plain), 5.69 KB, created by
Katrin Fischer
on 2020-08-26 20:38:50 UTC
(
hide
)
Description:
Bug 22789: (QA follow-up) Some minor formatting changes
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-08-26 20:38:50 UTC
Size:
5.69 KB
patch
obsolete
>From 2bbaebf7e939a80efefbd4fd1a3bb3c730958e3c Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 26 Aug 2020 22:36:09 +0200 >Subject: [PATCH] Bug 22789: (QA follow-up) Some minor formatting changes > >- Remove the unordered list added to the holds list Details column >- Switch div to span to have the hint appear behind the checkbox > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/includes/holds_table.inc | 56 +++++++++------------- > .../prog/en/modules/reserve/request.tt | 2 +- > 2 files changed, 23 insertions(+), 35 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 01dfed3171..f3aed75062 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -140,53 +140,41 @@ > </td> > > <td> >- <ul> > [% IF ( hold.found ) %] >- <li> >- <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> >- [% IF ( hold.barcodenumber ) %] >- [% hold.barcodenumber | html %] >- <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> >- [% ELSE %] >- No barcode >- [% END %] >- </a> >- </li> >+ <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> >+ [% IF ( hold.barcodenumber ) %] >+ [% hold.barcodenumber | html %] >+ <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> >+ [% ELSE %] >+ No barcode >+ [% END %] >+ </a> > [% ELSE %] > [% IF ( hold.item_level_hold ) %] >- <li> >- <i> >- Only item >- <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> >- [% IF ( hold.barcodenumber ) %] >- [% hold.barcodenumber | html %] >- <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> >- [% ELSE %] >- No barcode >- [% END %] >- </a> >- </i> >- </li> >+ <i> >+ Only item >+ <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> >+ [% IF ( hold.barcodenumber ) %] >+ [% hold.barcodenumber | html %] >+ <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> >+ [% ELSE %] >+ No barcode >+ [% END %] >+ </a> >+ </i> > [% ELSE %] > [% IF hold.itemtype %] >- <li> >- <i>Next available [% ItemTypes.GetDescription( hold.itemtype ) | html %] item</i> >- </li> >+ <i>Next available [% ItemTypes.GetDescription( hold.itemtype ) | html %] item</i> > [% ELSE %] >- <li> >- <i>Next available</i> >- </li> >+ <i>Next available</i> > [% END %] > > <input type="hidden" name="itemnumber" value="" /> > [% END %] > [% END %] > [% IF hold.non_priority %] >- <li> >- <i>Non priority hold</i> >- </li> >+ <br><i>Non priority hold</i> > [% END %] >- </ul> > </td> > > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 36ca0a538f..984a71c415 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -480,7 +480,7 @@ > <li id="non_priority_list_item"> > <label for="non_priority">Non priority hold:</label> > <input name="non_priority" id="non_priority" type="checkbox" /> >- <div class="hint">A non priority hold doesn't prevent a current checkout from renewing</div> >+ <span class="hint">A non priority hold doesn't prevent a current checkout from renewing</span> > </li> > </ol> > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22789
:
108703
|
108704
|
108705
|
108706
|
108707
|
108708
|
108709
|
108710
|
109123
|
109124
|
109125
|
109126
|
109127
|
109128
|
109129
|
109200
|
109201
|
109202
|
109203
|
109204
| 109205