Bugzilla – Attachment 10925 Details for
Bug 4198
deleting an authority refreshes the page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 4198 - Followup - PerlTidy authorities-home.pl
0002-Bug-4198-Followup-PerlTidy-authorities-home.pl.patch (text/plain), 3.58 KB, created by
Frédéric Demians
on 2012-07-18 07:44:04 UTC
(
hide
)
Description:
Bug 4198 - Followup - PerlTidy authorities-home.pl
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2012-07-18 07:44:04 UTC
Size:
3.58 KB
patch
obsolete
>From 5c4905ae57ecf8247c06a70b720e0e4a2547eafd Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Jul 2012 10:36:39 -0400 >Subject: [PATCH 2/2] Bug 4198 - Followup - PerlTidy authorities-home.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> >--- > authorities/authorities-home.pl | 48 +++++++++++++++++++++-------------------- > 1 file changed, 25 insertions(+), 23 deletions(-) > >diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl >index 02684b3..bc565d1 100755 >--- a/authorities/authorities-home.pl >+++ b/authorities/authorities-home.pl >@@ -31,20 +31,24 @@ use C4::Acquisition; > use C4::Koha; # XXX subfield_is_koha_internal_p > use C4::Biblio; > >-my $query = new CGI; >-my $op = $query->param('op'); >+my $query = new CGI; >+my $op = $query->param('op'); > $op ||= q{}; > my $authtypecode = $query->param('authtypecode'); > $authtypecode ||= q{}; >-my $dbh = C4::Context->dbh; >+my $dbh = C4::Context->dbh; > > my $authid = $query->param('authid'); > my ( $template, $loggedinuser, $cookie ); > > my $authtypes = getauthtypes; > my @authtypesloop; >-foreach my $thisauthtype ( sort { $authtypes->{$a}{'authtypetext'} cmp $authtypes->{$b}{'authtypetext'} } >- keys %$authtypes ) >+foreach my $thisauthtype ( >+ sort { >+ $authtypes->{$a}{'authtypetext'} cmp $authtypes->{$b}{'authtypetext'} >+ } >+ keys %$authtypes >+ ) > { > my %row = ( > value => $thisauthtype, >@@ -66,7 +70,7 @@ if ( $op eq "delete" ) { > } > ); > &DelAuthority( $authid, 1 ); >- >+ > $op = "do_search"; > } > if ( $op eq "do_search" ) { >@@ -115,19 +119,19 @@ if ( $op eq "do_search" ) { > # next/previous would not work anymore > my @marclist_ini = $query->param('marclist'); > for ( my $i = 0 ; $i <= $#marclist ; $i++ ) { >- if ($value[$i]){ >- push @field_data, { term => "marclist", val => $marclist_ini[$i] }; >- if (!defined $and_or[$i]) { >- $and_or[$i] = q{}; >- } >- push @field_data, { term => "and_or", val => $and_or[$i] }; >- if (!defined $excluding[$i]) { >- $excluding[$i] = q{}; >- } >- push @field_data, { term => "excluding", val => $excluding[$i] }; >- push @field_data, { term => "operator", val => $operator[$i] }; >- push @field_data, { term => "value", val => $value[$i] }; >- } >+ if ( $value[$i] ) { >+ push @field_data, { term => "marclist", val => $marclist_ini[$i] }; >+ if ( !defined $and_or[$i] ) { >+ $and_or[$i] = q{}; >+ } >+ push @field_data, { term => "and_or", val => $and_or[$i] }; >+ if ( !defined $excluding[$i] ) { >+ $excluding[$i] = q{}; >+ } >+ push @field_data, { term => "excluding", val => $excluding[$i] }; >+ push @field_data, { term => "operator", val => $operator[$i] }; >+ push @field_data, { term => "value", val => $value[$i] }; >+ } > } > > # construction of the url of each page >@@ -148,7 +152,7 @@ if ( $op eq "do_search" ) { > > my $from = ( $startfrom - 1 ) * $resultsperpage + 1; > my $to; >- if (!defined $total) { >+ if ( !defined $total ) { > $total = 0; > } > >@@ -187,9 +191,7 @@ if ( $op eq '' ) { > > } > >-$template->param( >- authtypesloop => \@authtypesloop, >-); >+$template->param( authtypesloop => \@authtypesloop, ); > > $template->{VARS}->{marcflavour} = C4::Context->preference("marcflavour"); > >-- >1.7.11.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4198
:
1900
|
10646
|
10647
|
10924
| 10925