Attachment 109290 Details for Bug 20057 – Bug 20057: Fix capitalization and rephrase system preference as a sentence

[patch] Bug 20057: Fix capitalization and rephrase system preference as a sentence

Bug-20057-Fix-capitalization-and-rephrase-system-p.patch (text/plain), 3.26 KB, created by Nick Clemens (kidclamp) on 2020-08-28 14:42:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-08-28 14:42:27 UTC

Size: 3.26 KB

patch

obsolete

>From 853755439c8a38fd81c7ef7e3dbc96729649e208 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sat, 23 May 2020 06:23:37 +0000
>Subject: [PATCH] Bug 20057: Fix capitalization and rephrase system preference
> as a sentence
>
>This makes changes to strings involved in this feature:
>- Rephrases the system preference description into a sentence
>- Rephrases message shown in OPAC on submitting (library has not actively
>  approved, so just say that the record has been modified)
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> installer/data/mysql/atomicupdate/AutoApprovePatronProfileSettings.sql | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref | 3 ++-
> .../bootstrap/en/modules/opac-memberentry-update-submitted.tt          | 2 +-
> 3 files changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/AutoApprovePatronProfileSettings.sql b/installer/data/mysql/atomicupdate/AutoApprovePatronProfileSettings.sql
>index 55f54def46..d7c0104468 100644
>--- a/installer/data/mysql/atomicupdate/AutoApprovePatronProfileSettings.sql
>+++ b/installer/data/mysql/atomicupdate/AutoApprovePatronProfileSettings.sql
>@@ -1,2 +1,2 @@
> INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type`) VALUES
>-('AutoApprovePatronProfileSettings', '0', '', 'Automatically approve Patron profile changes.', 'YesNo');
>+('AutoApprovePatronProfileSettings', '0', '', 'Automatically approve patron profile changes from the OPAC.', 'YesNo');
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>index be281c43e0..4a6396eab2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
>@@ -78,7 +78,8 @@ Patrons:
>            choices:
>                yes: Enable
>                no: Disable
>-         - "Automatically approve Patron profile changes."
>+         - "automatic approval of patron detail changes from the OPAC."
>+         - Requires OPACPatronDetails to be activated.
>      -
>          - pref: ProtectSuperlibrarianPrivileges
>            choices:
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt
>index 5a2bd8461d..1b3d285c37 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry-update-submitted.tt
>@@ -26,7 +26,7 @@
>                         <div class="alert alert-success">
>                             <h3>Thank you</h3>
>                           [% IF ( Koha.Preference('AutoApprovePatronProfileSettings') ) %]
>-                            <p>Your updates have been submitted and accepted by the library.</p>
>+                            <p>Your updates have been submitted and your patron account has been modified.</p>
>                           [% ELSE %]
>                             <p>Your updates have been submitted. A librarian will review your updates before applying them.</p>
>                           [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20057: 70790 | 70925 | 70926 | 70927 | 105075 | 105076 | 105142 | 105303 | 105304 | 105305 | 109288 | 109289 | 109290