Attachment 109390 Details for Bug 22417 – Bug 22417: Remove $dbh in Koha::BackgroundJob::*

[patch] Bug 22417: Remove $dbh in Koha::BackgroundJob::*

Bug-22417-Remove-dbh-in-KohaBackgroundJob.patch (text/plain), 1.69 KB, created by Jonathan Druart on 2020-09-01 09:01:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-09-01 09:01:53 UTC

Size: 1.69 KB

patch

obsolete

>From 6c7c75ce014175780816ed47d204bd03e9586624 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 1 Sep 2020 10:22:26 +0200
>Subject: [PATCH] Bug 22417: Remove $dbh in Koha::BackgroundJob::*
>
>Also remove unused $job_type var
>---
> Koha/BackgroundJob/BatchUpdateAuthority.pm | 2 --
> Koha/BackgroundJob/BatchUpdateBiblio.pm    | 4 ----
> 2 files changed, 6 deletions(-)
>
>diff --git a/Koha/BackgroundJob/BatchUpdateAuthority.pm b/Koha/BackgroundJob/BatchUpdateAuthority.pm
>index 3a7683dec2..24f1e9a400 100644
>--- a/Koha/BackgroundJob/BatchUpdateAuthority.pm
>+++ b/Koha/BackgroundJob/BatchUpdateAuthority.pm
>@@ -75,8 +75,6 @@ sub process {
>         total_success => 0,
>     };
>     my @messages;
>-    my $dbh = C4::Context->dbh;
>-    $dbh->{RaiseError} = 1;
>     RECORD_IDS: for my $record_id ( sort { $a <=> $b } @record_ids ) {
>         next unless $record_id;
>         # Authorities
>diff --git a/Koha/BackgroundJob/BatchUpdateBiblio.pm b/Koha/BackgroundJob/BatchUpdateBiblio.pm
>index 3549157b5d..2125b42c7f 100644
>--- a/Koha/BackgroundJob/BatchUpdateBiblio.pm
>+++ b/Koha/BackgroundJob/BatchUpdateBiblio.pm
>@@ -54,8 +54,6 @@ Process the modification.
> sub process {
>     my ( $self, $args ) = @_;
> 
>-    my $job_type = $args->{job_type};
>-
>     my $job = Koha::BackgroundJobs->find( $args->{job_id} );
> 
>     if ( !exists $args->{job_id} || !$job || $job->status eq 'cancelled' ) {
>@@ -79,8 +77,6 @@ sub process {
>         total_success => 0,
>     };
>     my @messages;
>-    my $dbh = C4::Context->dbh;
>-    $dbh->{RaiseError} = 1;
>     RECORD_IDS: for my $biblionumber ( sort { $a <=> $b } @record_ids ) {
> 
>         last if $job->get_from_storage->status eq 'cancelled';
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22417: 105542 | 105543 | 107385 | 107386 | 107387 | 107388 | 107389 | 107390 | 107391 | 107392 | 107393 | 107394 | 107395 | 107396 | 107397 | 107398 | 107399 | 107400 | 107401 | 107402 | 107403 | 107404 | 107405 | 107406 | 107481 | 107482 | 107682 | 108023 | 108024 | 108025 | 108026 | 108027 | 108028 | 108029 | 108030 | 108031 | 108032 | 108033 | 108034 | 108035 | 108036 | 108037 | 108038 | 108039 | 108040 | 108041 | 108042 | 108043 | 108044 | 108045 | 108046 | 108047 | 109270 | 109271 | 109319 | 109320 | 109321 | 109322 | 109323 | 109324 | 109325 | 109326 | 109327 | 109328 | 109329 | 109330 | 109331 | 109332 | 109333 | 109334 | 109335 | 109336 | 109337 | 109338 | 109339 | 109340 | 109341 | 109342 | 109343 | 109344 | 109345 | 109350 | 109351 | 109355 | 109390 | 109391 | 109392 | 109393 | 109394 | 109395 | 109396 | 109397 | 109398 | 109399 | 109400 | 109401 | 109402 | 109403 | 109404 | 109405 | 109406 | 109407 | 109408 | 109409 | 109410 | 109411 | 109412 | 109413 | 109414 | 109415 | 109416 | 109417 | 109418 | 109474 | 109475 | 109476 | 109477 | 110150 | 111091 | 111092 | 111093 | 111094 | 111095 | 111096 | 111097 | 111098 | 111099 | 111100 | 111101 | 111102 | 111103 | 111104 | 111105 | 111106 | 111107 | 111108 | 111109 | 111110 | 111111 | 111112 | 111113 | 111114 | 111115 | 111116 | 111117 | 111118 | 111119 | 111120 | 111121 | 111238 | 111239 | 111245