Bugzilla – Attachment 10940 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm
Bug-6679---SIGNED-OFFfix-9-perlcritic-violations-i.patch (text/plain), 2.73 KB, created by
Jonathan Druart
on 2012-07-18 13:14:10 UTC
(
hide
)
Description:
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-18 13:14:10 UTC
Size:
2.73 KB
patch
obsolete
>From f0ac373562caf13386389ba8c0dd0ebe2ab4270b Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 01:12:24 +1200 >Subject: [PATCH] =?UTF-8?q?Bug=206679=20-=20[SIGNED-OFF]=C2=A0fix=209=20perl?= > =?UTF-8?q?critic=20violations=20in=20C4/Koha.pm?= >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >- Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) > >- "return" statement with explicit "undef" at line 1112, column 4. See page 199 of PBP. (Severity: 5) > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Koha.pm | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/C4/Koha.pm b/C4/Koha.pm >index 4f386e4..b8b0582 100644 >--- a/C4/Koha.pm >+++ b/C4/Koha.pm >@@ -112,7 +112,7 @@ sub slashifyDate { > } > > # FIXME.. this should be moved to a MARC-specific module >-sub subfield_is_koha_internal_p ($) { >+sub subfield_is_koha_internal_p { > my ($subfield) = @_; > > # We could match on 'lib' and 'tab' (and 'mandatory', & more to come!) >@@ -471,7 +471,7 @@ sub getitemtypeimagesrc { > } > } > >-sub getitemtypeimagelocation($$) { >+sub getitemtypeimagelocation { > my ( $src, $image ) = @_; > > return '' if ( !$image ); >@@ -630,7 +630,7 @@ sub GetPrinters { > > =cut > >-sub GetPrinter ($$) { >+sub GetPrinter { > my ( $query, $printers ) = @_; # get printer for this query from printers > my $printer = $query->param('printer'); > my %cookie = $query->cookie('userenv'); >@@ -1109,7 +1109,7 @@ sub GetKohaAuthorisedValues { > } > return \%values; > } else { >- return undef; >+ return; > } > } > >@@ -1140,7 +1140,7 @@ sub GetKohaAuthorisedValuesFromField { > } > return \%values; > } else { >- return undef; >+ return; > } > } > >@@ -1242,7 +1242,7 @@ sub GetNormalizedISBN { > $isbn =~ s/(.*)( \| )(.*)/$1/; > return _isbn_cleanup($isbn); > } >- return undef unless $record; >+ return unless $record; > > if ($marcflavour eq 'UNIMARC') { > @fields = $record->field('010'); >@@ -1251,7 +1251,7 @@ sub GetNormalizedISBN { > if ($isbn) { > return _isbn_cleanup($isbn); > } else { >- return undef; >+ return; > } > } > } >@@ -1262,7 +1262,7 @@ sub GetNormalizedISBN { > if ($isbn) { > return _isbn_cleanup($isbn); > } else { >- return undef; >+ return; > } > } > } >@@ -1307,7 +1307,7 @@ sub GetNormalizedOCLCNumber { > $oclc =~ s/\(OCoLC\)//; > return $oclc; > } else { >- return undef; >+ return; > } > } > } >-- >1.7.7.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208