Attachment 109410 Details for Bug 22417 – Bug 22417: Remove record_type from BatchUpdate*

[patch] Bug 22417: Remove record_type from BatchUpdate*

Bug-22417-Remove-recordtype-from-BatchUpdate.patch (text/plain), 3.06 KB, created by Jonathan Druart on 2020-09-01 09:37:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-09-01 09:37:55 UTC

Size: 3.06 KB

patch

obsolete

>From db9c50392842bc7e99d2ac77d32d5c6b609a01f0 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 29 Jul 2020 10:34:50 +0200
>Subject: [PATCH] Bug 22417: Remove record_type from BatchUpdate*
>
>We don't need to pass it to the job, they each know which record type
>they are dealing with
>
>Signed-off-by: David Cook <dcook@prosentient.com.au>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/BackgroundJob/BatchUpdateAuthority.pm | 5 +----
> Koha/BackgroundJob/BatchUpdateBiblio.pm    | 5 +----
> tools/batch_record_modification.pl         | 1 -
> 3 files changed, 2 insertions(+), 9 deletions(-)
>
>diff --git a/Koha/BackgroundJob/BatchUpdateAuthority.pm b/Koha/BackgroundJob/BatchUpdateAuthority.pm
>index ed634d251d..f965f8da43 100644
>--- a/Koha/BackgroundJob/BatchUpdateAuthority.pm
>+++ b/Koha/BackgroundJob/BatchUpdateAuthority.pm
>@@ -31,7 +31,6 @@ sub process {
>         ->store;
> 
>     my $mmtid = $args->{mmtid};
>-    my $record_type = $args->{record_type};
>     my @record_ids = @{ $args->{record_ids} };
> 
>     my $report = {
>@@ -85,16 +84,14 @@ sub enqueue {
> 
>     # TODO Raise exception instead
>     return unless exists $args->{mmtid};
>-    return unless exists $args->{record_type}; #FIXME RMME
>     return unless exists $args->{record_ids};
> 
>     my $mmtid = $args->{mmtid};
>-    my $record_type = $args->{record_type};
>     my @record_ids = @{ $args->{record_ids} };
> 
>     $self->SUPER::enqueue({
>         job_size => scalar @record_ids,
>-        job_args => {mmtid => $mmtid, record_type => $record_type, record_ids => \@record_ids,}
>+        job_args => {mmtid => $mmtid, record_ids => \@record_ids,}
>     });
> }
> 
>diff --git a/Koha/BackgroundJob/BatchUpdateBiblio.pm b/Koha/BackgroundJob/BatchUpdateBiblio.pm
>index 16f2e218e9..301a2eb1b8 100644
>--- a/Koha/BackgroundJob/BatchUpdateBiblio.pm
>+++ b/Koha/BackgroundJob/BatchUpdateBiblio.pm
>@@ -35,7 +35,6 @@ sub process {
>         ->store;
> 
>     my $mmtid = $args->{mmtid};
>-    my $record_type = $args->{record_type};
>     my @record_ids = @{ $args->{record_ids} };
> 
>     my $report = {
>@@ -91,16 +90,14 @@ sub enqueue {
> 
>     # TODO Raise exception instead
>     return unless exists $args->{mmtid};
>-    return unless exists $args->{record_type}; #FIXME RMME
>     return unless exists $args->{record_ids};
> 
>     my $mmtid = $args->{mmtid};
>-    my $record_type = $args->{record_type};
>     my @record_ids = @{ $args->{record_ids} };
> 
>     $self->SUPER::enqueue({
>         job_size => scalar @record_ids,
>-        job_args => {mmtid => $mmtid, record_type => $record_type, record_ids => \@record_ids,}
>+        job_args => {mmtid => $mmtid, record_ids => \@record_ids,}
>     });
> }
> 
>diff --git a/tools/batch_record_modification.pl b/tools/batch_record_modification.pl
>index b28390d297..d9fa8c42d8 100755
>--- a/tools/batch_record_modification.pl
>+++ b/tools/batch_record_modification.pl
>@@ -153,7 +153,6 @@ if ( $op eq 'form' ) {
>     try {
>         my $params = {
>             mmtid       => $mmtid,
>-            record_type => $recordtype,
>             record_ids  => \@record_ids,
>         };
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22417: 105542 | 105543 | 107385 | 107386 | 107387 | 107388 | 107389 | 107390 | 107391 | 107392 | 107393 | 107394 | 107395 | 107396 | 107397 | 107398 | 107399 | 107400 | 107401 | 107402 | 107403 | 107404 | 107405 | 107406 | 107481 | 107482 | 107682 | 108023 | 108024 | 108025 | 108026 | 108027 | 108028 | 108029 | 108030 | 108031 | 108032 | 108033 | 108034 | 108035 | 108036 | 108037 | 108038 | 108039 | 108040 | 108041 | 108042 | 108043 | 108044 | 108045 | 108046 | 108047 | 109270 | 109271 | 109319 | 109320 | 109321 | 109322 | 109323 | 109324 | 109325 | 109326 | 109327 | 109328 | 109329 | 109330 | 109331 | 109332 | 109333 | 109334 | 109335 | 109336 | 109337 | 109338 | 109339 | 109340 | 109341 | 109342 | 109343 | 109344 | 109345 | 109350 | 109351 | 109355 | 109390 | 109391 | 109392 | 109393 | 109394 | 109395 | 109396 | 109397 | 109398 | 109399 | 109400 | 109401 | 109402 | 109403 | 109404 | 109405 | 109406 | 109407 | 109408 | 109409 | 109410 | 109411 | 109412 | 109413 | 109414 | 109415 | 109416 | 109417 | 109418 | 109474 | 109475 | 109476 | 109477 | 110150 | 111091 | 111092 | 111093 | 111094 | 111095 | 111096 | 111097 | 111098 | 111099 | 111100 | 111101 | 111102 | 111103 | 111104 | 111105 | 111106 | 111107 | 111108 | 111109 | 111110 | 111111 | 111112 | 111113 | 111114 | 111115 | 111116 | 111117 | 111118 | 111119 | 111120 | 111121 | 111238 | 111239 | 111245