Bugzilla – Attachment 109430 Details for
Bug 26332
Koha::Account::pay incorrectly defaults to '0' for manager_id
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26332: Remove hard coded '0' for manager_id
Bug-26332-Remove-hard-coded-0-for-managerid.patch (text/plain), 1.04 KB, created by
Martin Renvoize (ashimema)
on 2020-09-01 13:25:26 UTC
(
hide
)
Description:
Bug 26332: Remove hard coded '0' for manager_id
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-09-01 13:25:26 UTC
Size:
1.04 KB
patch
obsolete
>From 2418dc67902d43120112107bdc005b8af3fe6dad Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 1 Sep 2020 14:23:48 +0100 >Subject: [PATCH] Bug 26332: Remove hard coded '0' for manager_id > >This patch removes the fallback to '0' for the manager_id in >Koha::Account::pay. This will only affect plugins that contain a >background callback that doesn't set the user environment. >--- > Koha/Account.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Account.pm b/Koha/Account.pm >index 2a63856b52..5178d98639 100644 >--- a/Koha/Account.pm >+++ b/Koha/Account.pm >@@ -95,7 +95,7 @@ sub pay { > > my $patron = Koha::Patrons->find( $self->{patron_id} ); > >- my $manager_id = $userenv ? $userenv->{number} : 0; >+ my $manager_id = $userenv ? $userenv->{number} : undef; > my $interface = $params ? ( $params->{interface} || C4::Context->interface ) : C4::Context->interface; > Koha::Exceptions::Account::RegisterRequired->throw() > if ( C4::Context->preference("UseCashRegisters") >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26332
: 109430