Bugzilla – Attachment 10944 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm
0001-Bug-6679-fix-8-perlcritic-violations-in-C4-Circulati.patch (text/plain), 2.78 KB, created by
Jonathan Druart
on 2012-07-18 13:49:24 UTC
(
hide
)
Description:
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-18 13:49:24 UTC
Size:
2.78 KB
patch
obsolete
>From aad4413bba585aa7609b1a07a1a69c918ae174d7 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 01:20:37 +1200 >Subject: [PATCH 1/1] Bug 6679 - fix 8 perlcritic violations in > C4/Circulation.pm > >- "return" statement with explicit "undef" at line 994, column 39. See page 199 of PBP. (Severity: 5) >--- > C4/Circulation.pm | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 9508c78..0259b77 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -991,7 +991,7 @@ sub AddIssue { > } > if ($borrower and $barcode and $barcodecheck ne '0'){#??? wtf > # find which item we issue >- my $item = GetItem('', $barcode) or return undef; # if we don't get an Item, abort. >+ my $item = GetItem('', $barcode) or return; # if we don't get an Item, abort. > my $branch = _GetCircControlBranch($item,$borrower); > > # get actual issuing if there is one >@@ -1303,7 +1303,7 @@ sub GetIssuingRule { > return $irule if defined($irule) ; > > # if no rule matches, >- return undef; >+ return; > } > > =head2 GetBranchBorrowerCircRule >@@ -2175,7 +2175,7 @@ tables issues and the firstname,surname & cardnumber from borrowers. > > sub GetBiblioIssues { > my $biblionumber = shift; >- return undef unless $biblionumber; >+ return unless $biblionumber; > my $dbh = C4::Context->dbh; > my $query = " > SELECT issues.*,items.barcode,biblio.biblionumber,biblio.title, biblio.author,borrowers.cardnumber,borrowers.surname,borrowers.firstname >@@ -2353,13 +2353,13 @@ from the book's item type. > =cut > > sub AddRenewal { >- my $borrowernumber = shift or return undef; >- my $itemnumber = shift or return undef; >+ my $borrowernumber = shift or return; >+ my $itemnumber = shift or return; > my $branch = shift; > my $datedue = shift; > my $lastreneweddate = shift || DateTime->now(time_zone => C4::Context->tz)->ymd(); >- my $item = GetItem($itemnumber) or return undef; >- my $biblio = GetBiblioFromItemNumber($itemnumber) or return undef; >+ my $item = GetItem($itemnumber) or return; >+ my $biblio = GetBiblioFromItemNumber($itemnumber) or return; > > my $dbh = C4::Context->dbh; > # Find the issues record for this book >@@ -2380,7 +2380,7 @@ sub AddRenewal { > # based on the value of the RenewalPeriodBase syspref. > unless ($datedue) { > >- my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ) or return undef; >+ my $borrower = C4::Members::GetMember( borrowernumber => $borrowernumber ) or return; > my $itemtype = (C4::Context->preference('item-level_itypes')) ? $biblio->{'itype'} : $biblio->{'itemtype'}; > > $datedue = (C4::Context->preference('RenewalPeriodBase') eq 'date_due') ? >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208