Attachment 109457 Details for Bug 26313 – Bug 26313: "Show analytics" link must use uppercase for booleans

[patch] Bug 26313: "Show analytics" link must use uppercase for booleans

Bug-26313-Show-analytics-link-must-use-uppercase-f.patch (text/plain), 2.09 KB, created by Katrin Fischer on 2020-09-01 19:55:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-09-01 19:55:13 UTC

Size: 2.09 KB

patch

obsolete

>From fe01756092f905362a1ea9320aca5bf3a6cb4ee8 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 1 Sep 2020 12:32:56 +0000
>Subject: [PATCH] Bug 26313: "Show analytics" link must use uppercase for
> booleans
>
>In elasticsearch we only treat AND and OR as boolean operators if
>they are capitalized
>
>To test:
>- Turn SearchEngine to Elasticsearch and make sure it works
>- Pick any serial record in your database, make sure 001 is set
>- Go to new > new child record
>- Fill in 245 and save
>- Click on the "In" link, it should bring you to the parent record
>- Click on "Show analytics" => there will be no result
>- Apply patch
>- restart and reload
>- Try again
>- It works!
>- Switch SearchEngine syspref to 'Zebra'
>- Test again
>- It still works!
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index 31c094de00..87953b9727 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -326,7 +326,7 @@
>             <a>
>             <xsl:choose>
>             <xsl:when test="$UseControlNumber = '1' and marc:controlfield[@tag=001]">
>-                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+and+(bib-level:a+or+bib-level:b)</xsl:attribute>
>+                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+AND+(bib-level:a+OR+bib-level:b)</xsl:attribute>
>             </xsl:when>
>             <xsl:otherwise>
>                 <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=Host-item:<xsl:value-of select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:subfield[@code='a'], '/', ''), true())"/></xsl:attribute>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26313: 109423 | 109457 | 109458 | 109509 | 109510