Attachment 109506 Details for Bug 26327 – Bug 26327: Include transacting library in fines

[patch] Bug 26327: Include transacting library in fines

Bug-26327-Include-transacting-library-in-fines.patch (text/plain), 2.61 KB, created by Kyle M Hall (khall) on 2020-09-02 11:18:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-09-02 11:18:43 UTC

Size: 2.61 KB

patch

obsolete

>From af30d55c2afeff53d5d75426ac760e7a45d5322b Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Mon, 31 Aug 2020 16:35:10 -0300
>Subject: [PATCH] Bug 26327: Include transacting library in fines
>
>This patch introduces a new column on the fines table to display the
>checkout library when the fine is tied to a checkout.
>
>To test:
>1. Have an overdue item that generated a fee
>2. Look at the 'Accounting' tab, 'Make a payment'
>=> FAIL: There's no information about the library
>3. Apply this patch
>4. Restart all
>5. Reload and repeat 2
>=> SUCCESS: There's a column with the library name!
>6. Identify the issue_id for the mentioned checkout and:
> $ koha-mysql kohadev
> > UPDATE old_issues SET branchcode='TOM' WHERE issue_id=11;
> (i.e. set the branchcode to an invalid value, to emulate a deleted
> branch).
>7. Reload
>=> SUCCESS: It doesn't explode, it doesn't display a library name.
>8. Sign off :-D
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>index fa6c646053..c66aecbf2d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>@@ -53,6 +53,7 @@
> <th>Due date</th>
> <th>Checkin date</th>
> <th>Checkout date</th>
>+ <th class="checked_out_from">Checked out from</th>
> <th class="NoSort">Payment note</th>
> <th>Amount</th>
> <th>Amount outstanding</th>
>@@ -112,6 +113,11 @@
> [% line.checkout.issuedate | $KohaDates %]
> [% END %]
> </td>
>+ <td class="checked_out_from">
>+ [% IF line.issue_id && line.checkout.library %]
>+ [% line.checkout.library.branchname | html %]
>+ [% END %]
>+ </td>
> <td class="actions">
> <a href="#" class="add-note" data-accountlines_id="[% line.accountlines_id | html %]"> Add note</a>
> <input type="text" size="10" name="payment_note_[% line.accountlines_id | html %]" value="" /> <a href="#" class="cancel-note"></a>
>@@ -124,7 +130,7 @@
> 
> <tfoot>
> <tr>
>- <td class="total" colspan="11">Total due:</td>
>+ <td class="total" colspan="12">Total due:</td>
> <td style="text-align: right;">[% total | $Price %]</td>
> </tr>
> [% IF outstanding_credits.total_outstanding < 0 %]
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26327: 109376 | 109377 | 109378 | 109505 | 109506 | 109507 | 109531 | 110412 | 110421 | 110422 | 110423 | 110424 | 110425 | 111417 | 111420 | 111421 | 111422 | 111423 | 111424 | 111586