Attachment 109510 Details for Bug 26313 – Bug 26313: (follow-up) Fix OPAC and "Show volumes" links

[patch] Bug 26313: (follow-up) Fix OPAC and "Show volumes" links

Bug-26313-follow-up-Fix-OPAC-and-Show-volumes-link.patch (text/plain), 4.77 KB, created by Tomás Cohen Arazi (tcohen) on 2020-09-02 12:26:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-09-02 12:26:43 UTC

Size: 4.77 KB

patch

obsolete

>From cdf7b34a7e96d103c94ba68d762d10134a2b095c Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Tue, 1 Sep 2020 21:22:31 +0200
>Subject: [PATCH] Bug 26313: (follow-up) Fix OPAC and "Show volumes" links
>
>Elasticsearch requires the booleans in search requests to
>be uppercase. This fixes the "Show analytics" link in
>OPAC (same as first patch for intranet) and the "Show volume"
>link.
>
>To test both patches:
>
>Set UseControlNumber = Use
>
>1) "Show analytics"
>- Turn SearchEngine to Elasticsearch and make sure it works
>- Pick any serial record in your database, make sure 001 is set
>- Go to new > new child record
>- Fill in 245 and save
>- For both staff and OPAC:
>  - Click on the "In" link, it should bring you to the parent record
>  - Click on "Show analytics", it should show your analytical record
>- Switch to "Zebra" - verify links still work.
>
>2) "Show volumes"
>- Turn SearchEngine to Elasticsearch again
>- Pick any serial record in your database, make sure 001 is set
>- Set LDR, pos. 19 = a - Set
>- Note 001 value
>- Find another record and edit it
>- Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work)
>- Set 773$ title of set record $w 001 of set record
>- For both staff and OPAC:
>  - Click on the "In: link, it should bring up your set record
>  - Click on the "Show volumes" link, it should bring up the volume
>
>- Switch to "Zebra" - verify all links still work.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl  | 2 +-
> .../opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl     | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>index 87953b9727..fc88cec6fd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
>@@ -343,7 +343,7 @@
>             <a>
>             <xsl:choose>
>             <xsl:when test="$UseControlNumber = '1' and marc:controlfield[@tag=001]">
>-                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+not+(bib-level:a+or+bib-level:b)</xsl:attribute>
>+                <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+NOT+(bib-level:a+OR+bib-level:b)</xsl:attribute>
>             </xsl:when>
>             <xsl:otherwise>
>                 <xsl:attribute name="href">/cgi-bin/koha/catalogue/search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:subfield[@code='a'], '/', ''), true())"/></xsl:attribute>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>index 8286a94fc4..10fcd84baa 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
>@@ -345,7 +345,7 @@
>             <a>
>             <xsl:choose>
>             <xsl:when test="$UseControlNumber = '1' and marc:controlfield[@tag=001]">
>-                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+and+(bib-level:a+or+bib-level:b)</xsl:attribute>
>+                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+AND+(bib-level:a+OR+bib-level:b)</xsl:attribute>
>             </xsl:when>
>             <xsl:otherwise>
>                 <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=Host-item:<xsl:value-of select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:subfield[@code='a'], '/', ''), true())"/></xsl:attribute>
>@@ -362,7 +362,7 @@
>             <a>
>             <xsl:choose>
>             <xsl:when test="$UseControlNumber = '1' and marc:controlfield[@tag=001]">
>-                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+not+(bib-level:a+or+bib-level:b)</xsl:attribute>
>+                <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=rcn:<xsl:value-of select="str:encode-uri(marc:controlfield[@tag=001], true())"/>+NOT+(bib-level:a+OR+bib-level:b)</xsl:attribute>
>             </xsl:when>
>             <xsl:otherwise>
>                 <xsl:attribute name="href">/cgi-bin/koha/opac-search.pl?q=ti,phr:<xsl:value-of select="str:encode-uri(translate(marc:datafield[@tag=245]/marc:subfield[@code='a'], '/', ''), true())"/></xsl:attribute>
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 26313: 109423 | 109457 | 109458 | 109509 | 109510