Attachment 109528 Details for Bug 23816 – Bug 23816: (QA follow-up) Use existing form validation to validate min password length

[patch] Bug 23816: (QA follow-up) Use existing form validation to validate min password length

Bug-23816-QA-follow-up-Use-existing-form-validatio.patch (text/plain), 2.19 KB, created by Tomás Cohen Arazi (tcohen) on 2020-09-02 12:55:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-09-02 12:55:18 UTC

Size: 2.19 KB

patch

obsolete

>From 634222d4d9e011fb249a689155f0c3f5f1b3d61f Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Thu, 27 Aug 2020 20:07:16 +0200
>Subject: [PATCH] Bug 23816: (QA follow-up) Use existing form validation to
> validate min password length
>
>The pattern check didn't work for me, but I figured we might
>want to use the same validation as for the other numeric fields
>on the form instead (upper age limit, etc.)
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/categories.js               | 3 +++
> 2 files changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>index 99dac40f52..37c6687d33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>@@ -231,7 +231,7 @@
>                 </li>
>                 <li>
>                     <label for="min_password_length">Minimum password length:</label>
>-                    <input id="min_password_length" type="text" inputmode="numeric" pattern="[0-9]*" name="min_password_length" value="[% category.min_password_length | html %]"/>
>+                    <input id="min_password_length" type="text" inputmode="numeric" name="min_password_length" value="[% category.min_password_length | html %]"/>
>                     <span>Leave blank to use system default ([% Koha.Preference('minPasswordLength') | html %])</span>
>                 </li>
>                 <li class="pwd_setting_wrapper">
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/categories.js b/koha-tmpl/intranet-tmpl/prog/js/categories.js
>index 4b6ac15017..8031fff535 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/categories.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/categories.js
>@@ -84,6 +84,9 @@ $(document).ready(function() {
>             },
>             category_type: {
>                 required: true
>+            },
>+            min_password_length: {
>+                digits: true
>             }
>         },
>         messages: {
>-- 
>2.28.0

Actions: View | Diff | Splinter Review

Attachments on bug 23816: 103099 | 103100 | 103101 | 103102 | 103103 | 103104 | 103108 | 103109 | 103110 | 103111 | 103112 | 103113 | 103805 | 103806 | 103807 | 103808 | 103809 | 103810 | 107158 | 107159 | 107160 | 107161 | 107162 | 107163 | 108554 | 108555 | 108556 | 108557 | 108558 | 108559 | 108571 | 108572 | 109243 | 109244 | 109245 | 109249 | 109250 | 109251 | 109252 | 109253 | 109254 | 109255 | 109256 | 109257 | 109520 | 109521 | 109522 | 109523 | 109524 | 109525 | 109526 | 109527 | 109528 | 109833 | 109834