Attachment 109554 Details for Bug 24197 – Bug 24197: (QA follow-up) Embelished syspref description

[patch] Bug 24197: (QA follow-up) Embelished syspref description

Bug-24197-QA-follow-up-Embelished-syspref-descript.patch (text/plain), 4.83 KB, created by Nick Clemens (kidclamp) on 2020-09-02 17:34:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-09-02 17:34:14 UTC

Size: 4.83 KB

patch

obsolete

>From 5fd54fdef98047fae1f0471fc587eaa43a78771c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 2 Sep 2020 16:33:06 +0100
>Subject: [PATCH] Bug 24197: (QA follow-up) Embelished syspref description
>
>As requested, I have embelished the syspref description to more
>accurately depict the fallback sequence for email delivery.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../bug_24197-new_RedirectAddressForFailedOverdueNotices_syspref.sql    | 2 +-
> installer/data/mysql/sysprefs.sql                                       | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref    | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_24197-new_RedirectAddressForFailedOverdueNotices_syspref.sql b/installer/data/mysql/atomicupdate/bug_24197-new_RedirectAddressForFailedOverdueNotices_syspref.sql
>index b33602cdf0..36e30f9881 100644
>--- a/installer/data/mysql/atomicupdate/bug_24197-new_RedirectAddressForFailedOverdueNotices_syspref.sql
>+++ b/installer/data/mysql/atomicupdate/bug_24197-new_RedirectAddressForFailedOverdueNotices_syspref.sql
>@@ -1 +1 @@
>-INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('RedirectAddressForFailedOverdueNotices', '', NULL, 'Destination email for failed overdue notices. If left empty then the individual library email or KohaAdminEmailAddress syspref will be the email address that failed overdue notices are sent to', 'free');
>+INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('RedirectAddressForFailedOverdueNotices', '', NULL, 'Destination email for failed overdue notices. If left empty then it will fallback to the first defined address in the following list: Library ReplyTo, Library Email, ReplytoDefault and KohaAdminEmailAddress', 'free');
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 06f297a1d3..c9d0ad2199 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -529,7 +529,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('QuoteOfTheDay','','intranet,opac','Enable or disable display of Quote of the Day on the OPAC and staff interface home page','multiple'),
> ('RandomizeHoldsQueueWeight','0',NULL,'if ON, the holds queue in circulation will be randomized, either based on all location codes, or by the location codes specified in StaticHoldsQueueWeight','YesNo'),
> ('RecordLocalUseOnReturn','0',NULL,'If ON, statistically record returns of unissued items as local use, instead of return','YesNo'),
>-('RedirectAddressForFailedOverdueNotices', '', NULL, 'Destination email for failed overdue notices. If left empty then the individual library email or KohaAdminEmailAddress syspref will be the email address that failed overdue notices are sent to', 'free'),
>+('RedirectAddressForFailedOverdueNotices', '', NULL, 'Destination email for failed overdue notices. If left empty then it will fallback to the first defined address in the following list: Library ReplyTo, Library Email, ReplytoDefault and KohaAdminEmailAddress', 'free'),
> ('RefundLostOnReturnControl','CheckinLibrary','CheckinLibrary|ItemHomeBranch|ItemHoldingBranch','If a lost item is returned, choose which branch to pick rules for refunding.','Choice'),
> ('RenewAccruingItemWhenPaid','0','','If enabled, when the fines on an item accruing is paid off, attempt to renew that item. If the syspref "RenewalPeriodBase" is set to "due date", renewed items may still be overdue','YesNo'),
> ('RenewAccruingItemInOpac','0','','If enabled, when the fines on an item accruing is paid off in the OPAC via a payment plugin, attempt to renew that item. If the syspref "RenewalPeriodBase" is set to "due date", renewed items may still be overdue','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index 28dfc2d685..470d49d7a9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -24,7 +24,7 @@ Administration:
>             - "Email address failed overdue notices are sent to: "
>             - pref: RedirectAddressForFailedOverdueNotices
>               class: email
>-            - "If left empty then the individual library email or KohaAdminEmailAddress will be set as the destination address for failed overdue notices"
>+            - "If left empty then it will fallback to the first defined address in the following list: Library ReplyTo, Library Email, ReplytoDefault and KohaAdminEmailAddress"
>         -
> 
>             - "How much debugging information to show in the browser when an internal error occurs: "
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 24197: 96123 | 96124 | 96125 | 103428 | 103429 | 103465 | 103466 | 109549 | 109550 | 109551 | 109552 | 109553 | 109554 | 109555