Bugzilla – Attachment 109569 Details for
Bug 26362
Overdue report shows incorrect branches for patron, holdingbranch, and homebranch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26362: Show correct libraries in overdues report
Bug-26362-Show-correct-libraries-in-overdues-repor.patch (text/plain), 3.29 KB, created by
David Cook
on 2020-09-03 05:42:30 UTC
(
hide
)
Description:
Bug 26362: Show correct libraries in overdues report
Filename:
MIME Type:
Creator:
David Cook
Created:
2020-09-03 05:42:30 UTC
Size:
3.29 KB
patch
obsolete
>From 5559ade817e46b71810fb65812188c41fbd808c1 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 3 Sep 2020 05:40:57 +0000 >Subject: [PATCH] Bug 26362: Show correct libraries in overdues report > >Currently the overdues report does the following display: >Patron library = home branch >Home library = holding branch >Holding library = patron branch > >This patch corrects the display of libraries in the overdues report. > >To test: > >0) Do not apply patch >1) Go to http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 >2) Go to http://localhost:8081/cgi-bin/koha/circ/set-library.pl >3) Choose "Troy" >4) http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 >5) Checkout "39999000004571" with due date of "09/01/2019 23:59" > >Note the facts: >Patron library = Centerville >Home library = Fairview >Holding library = Troy > >6) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl >7) Change "Columns" visibility to show Holding and Home libraries >8) Note that the libraries are incorrect: > >Patron library appears to be: Fairview >Home library appears to be: Troy >Holding library appears to be: Centerville > >9) Apply the patch >10) koha-plack --restart kohadev >11) Go to http://localhost:8081/cgi-bin/koha/circ/overdue.pl >12) Change "Columns" visibility to show Holding and Home libraries >13) Note that the libraries are correct: > >Patron library appears to be: Centerville >Home library appears to be: Fairview >Holding library appears to be: Troy >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 422b42f5ab..f95dfe8eb9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -78,10 +78,10 @@ > [% IF ( overdueloo.phone ) %]([% overdueloo.phone | html %])[% ELSIF ( overdueloo.mobile ) %]([% overdueloo.mobile | html %])[% ELSIF ( overdueloo.phonepro ) %]([% overdueloo.phonepro | html %])[% END %]</td> > [% END %] > <td>[% Categories.GetName( overdueloo.patron.categorycode ) | html %]</td> >- <td>[% Branches.GetName( overdueloo.homebranchcode ) | html %]</td> >+ <td>[% Branches.GetName( overdueloo.patron.branchcode ) | html %]</td> > <td>[% INCLUDE 'biblio-default-view.inc' biblionumber = overdueloo.biblionumber %][% INCLUDE 'biblio-title.inc' biblio=overdueloo %]</a> [% IF ( overdueloo.author ) %], by [% overdueloo.author | html %][% END %][% IF ( overdueloo.enumchron ) %], [% overdueloo.enumchron | html %][% END %]</td> >+ <td>[% Branches.GetName( overdueloo.homebranchcode ) | html %]</td> > <td>[% Branches.GetName( overdueloo.holdingbranchcode ) | html %]</td> >- <td>[% Branches.GetName( overdueloo.patron.branchcode ) | html %]</td> > <td><a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% overdueloo.biblionumber | uri %]&itemnumber=[% overdueloo.itemnum | uri %]#item[% overdueloo.itemnum | uri %]">[% overdueloo.barcode | html %]</a></td> > <td>[% overdueloo.itemcallnumber | html %]</td> > <td>[% ItemTypes.GetDescription( overdueloo.itemtype ) | html %]</td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26362
:
109569
|
109570
|
109598