Bugzilla – Attachment 109577 Details for
Bug 23091
Add options to charge new or restore forgiven overdues when a lost item is returned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23091: Outline of tests to be written
Bug-23091-Outline-of-tests-to-be-written.patch (text/plain), 2.18 KB, created by
Martin Renvoize (ashimema)
on 2020-09-03 06:42:36 UTC
(
hide
)
Description:
Bug 23091: Outline of tests to be written
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-09-03 06:42:36 UTC
Size:
2.18 KB
patch
obsolete
>From ba3af1adb0fb403b0a54a9ac6243c226aac0a8f9 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 15 Jul 2020 11:23:38 +0100 >Subject: [PATCH] Bug 23091: Outline of tests to be written > >Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> >--- > t/db_dependent/Circulation.t | 37 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 35 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 83761ad06c..e3e369b7ca 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -18,7 +18,7 @@ > use Modern::Perl; > use utf8; > >-use Test::More tests => 48; >+use Test::More tests => 49; > use Test::Exception; > use Test::MockModule; > use Test::Deep qw( cmp_deeply ); >@@ -2345,7 +2345,7 @@ subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub { > > > subtest 'AddReturn | is_overdue' => sub { >- plan tests => 8; >+ plan tests => 9; > > t::lib::Mocks::mock_preference('MarkLostItemsAsReturned', 'batchmod|moredetail|cronjob|additem|pendingreserves|onpayment'); > t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1); >@@ -2658,6 +2658,39 @@ subtest 'AddReturn | is_overdue' => sub { > Koha::Account::Lines->search( > { borrowernumber => $patron->borrowernumber } )->delete; > }; >+ >+ subtest 'enh 23091 | Lost item return policies' => sub { >+ plan tests => 1; >+ >+ ok(1); >+ >+ # Do nothing >+ # >+ # Refund fee >+ ## Without fee >+ ## With fee >+ # >+ # Refund fee and restore fine >+ ## Without fee >+ ### Without fine >+ ### With fine (forgiven) >+ ### With fine (unforgiven) >+ ## With fee >+ ### Without fine >+ ### With fine (forgiven) >+ ### With fine (unforgiven) >+ # >+ # Refund fee and charge new fine >+ ## Without fee >+ ### Without fine >+ ### With fine (forgiven) >+ ### With fine (unforgiven) >+ ## With fee >+ ### Without fine >+ ### With fine (forgiven) >+ ### With fine (unforgiven) >+ ### Backdated return >+ }; > }; > > subtest '_RestoreOverdueForLostAndFound' => sub { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23091
:
96217
|
105529
|
105530
|
105531
|
105544
|
105545
|
105546
|
105547
|
105567
|
105649
|
106871
|
106872
|
106873
|
106874
|
106875
|
106876
|
106906
|
106907
|
106908
|
106909
|
106910
|
106911
|
106912
|
106961
|
107026
|
107027
|
107028
|
107029
|
107030
|
107031
|
107032
|
107033
|
107034
|
107100
|
107101
|
107102
|
107103
|
107104
|
107105
|
107106
|
107107
|
107108
|
107335
|
107336
|
107337
|
107338
|
107339
|
107340
|
107341
|
107342
|
107343
|
108718
|
108719
|
108720
|
108721
|
108722
|
108723
|
108724
|
109571
|
109572
|
109573
|
109574
|
109575
|
109576
|
109577
|
110660
|
110661
|
110662
|
110663
|
110664
|
110665
|
110666
|
110667
|
110720
|
110721
|
110722
|
110723
|
110724
|
110725
|
110726
|
110727
|
111501
|
111502
|
111503
|
111504
|
111505
|
111506
|
111507
|
111508
|
111935
|
111936
|
111965
|
111979
|
111980
|
111981
|
111982
|
111983
|
111984
|
111985
|
111986
|
111987
|
111988
|
111989
|
113081
|
113082
|
113083
|
113084
|
113085
|
113086
|
113087
|
113088
|
113089
|
113090
|
113091