Attachment 109649 Details for Bug 26007 – Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

[patch] Bug 26007: Add/fix warning for changes to the Koha to MARC mappings

Bug-26007-Addfix-warning-for-changes-to-the-Koha-t.patch (text/plain), 3.91 KB, created by Marcel de Rooy on 2020-09-04 09:39:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2020-09-04 09:39:56 UTC

Size: 3.91 KB

patch

obsolete

>From 08530cd5390675ce319bde40ee9a6142dd57e429 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 30 Aug 2020 22:31:32 +0200
>Subject: [PATCH] Bug 26007: Add/fix warning for changes to the Koha to MARC
> mappings
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>Content-Type: text/plain; charset=utf-8
>
>There are 2 pages where one can change the Koha to MARC mappings in Koha:
>
>- When editing the configuration for a MARC subfield
>- On administration > Koha 2 MARC mappings
>
>This patch adds a warning that the batchRebuildBiblioTables script
>must be run if the mapping is changed.
>
>To test:
>- Go to Administration > MARC bibliographic frameworks >
>  Any framework > MARC structure > Any field > Edit subfield
>- ÃThe hint about the batchRebuildBiblioTables will be on "Link"
>  instead of "Koha Link". This is wrong as the link doesn't care
>  about the mappings.
>- Go to Administration > Koha to MARC mappings
>- Verify there is no hint
>- Apply patch
>- Verify both pages now show an appropriate message
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>This commit message is not completely accurate. See the follow-ups.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt    | 1 +
> .../prog/en/modules/admin/marc_subfields_structure.tt              | 7 ++++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt
>index 8dbadc49e8..8441157450 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt
>@@ -19,6 +19,7 @@
> 
> <h1>Koha to MARC mapping</h1>
> <br/>
>+<div class="dialog message">If you make any change to the mappings, you must ask your administrator to run misc/batchRebuildBiblioTables.pl.</div>
> <form action="/cgi-bin/koha/admin/koha2marclinks.pl" method="post" id="koha2marc">
> 
> [% IF error_add %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>index bf9c77095d..bd47cb9898 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
>@@ -156,7 +156,11 @@
>                     [% END %]
>                     (if checked, it means that the subfield is a URL and can be clicked)
>                 </li>
>-                <li><label for="link[% loo.row | html %]">Link:</label><input type="text" id="link[% loo.row | html %]" name="link" value="[% loo.link | html %]" size="10" maxlength="80" /> (e.g., Title or Local-Number) <span class="error"><em>NOTE: If you change this value you must ask your administrator to run misc/batchRebuildBiblioTables.pl.</em></span></li>
>+                <li>
>+                    <label for="link[% loo.row | html %]">Link:</label>
>+                    <input type="text" id="link[% loo.row | html %]" name="link" value="[% loo.link | html %]" size="10" maxlength="80" />
>+                    (an index name, e.g. title or Local-Number)
>+                </li>
>                 <li>
>                     <label for="kohafield[% loo.row | html %]">Koha link:</label>
>                     
>@@ -169,6 +173,7 @@
>                       [% END %]
>                     [% END %]
>                     </select>
>+                    <span class="error">(If you change this value, you must ask your administrator to run misc/batchRebuildBiblioTables.pl.)</span>
>                     
>                     <input type="hidden" name="kohafield" value="[% loo.kohafield | html %]"/>
>                 </li>
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26007: 109301 | 109302 | 109638 | 109649 | 109650 | 109651 | 109652 | 109881