Attachment 109667 Details for Bug 26299 – Bug 26299: Use same SMS number help text in OPAC as staff interface

[patch] Bug 26299: Use same SMS number help text in OPAC as staff interface

Bug-26299-Use-same-SMS-number-help-text-in-OPAC-as.patch (text/plain), 3.33 KB, created by Alexis Ripetti on 2020-09-04 15:00:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexis Ripetti

Created: 2020-09-04 15:00:47 UTC

Size: 3.33 KB

patch

obsolete

>From 86b88fe3f9a3bf59ceb5dd6c9815fc963fb1883c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 3 Sep 2020 13:25:45 +0000
>Subject: [PATCH] Bug 26299: Use same SMS number help text in OPAC as staff
> interface
>
>The SMS number help text in the OPAC follows a North American phone
>number style. It should be more generic. To that end, this patch
>makes the OPAC use the same help text for SMS numbers as
>the staff interface
>
>To test:
>1) Apply the patch
>2) Set "SMSSendDriver" to "Anything" in global system preferences
>3) Go to the following link and note the help text by SMS number
>http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51
>4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl
>5) Note that the help text in both interfaces uses the same wording
>
>Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com>
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 28d0ba3ffb..299311f6dd 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1408,7 +1408,7 @@ legend:hover {
> 
> <label for="SMSnumber">SMS number:</label>
> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" />
>- SMS number should be in the format 1234567890 or +11234567890
>+ Please enter numbers only. Prefix the number with + if including the country code.
> 
> [% UNLESS nosms_provider_id %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 4367c513f1..ea5122041f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -133,7 +133,7 @@
> <ol><li><label>Notice:</label>Some charges for text messages may be incurred when using this service. Please check with your mobile service provider if you have questions.</li></ol>
> <ol><li>
> <label for="SMSnumber">SMS number:</label> <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^\+?[1-9]\d{1,14}$" />
>- Please enter numbers only. (123) 456-7890 would be entered as 1234567890.
>+ Please enter numbers only. Prefix the number with + if including the country code.
> </li></ol>
> [% END %]
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 26299: 109136 | 109183 | 109191 | 109625 | 109667 | 109991