Bugzilla – Attachment 10972 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/VirtualShelves.pm, and comment-out obselete sub()
0001-Bug-6679-SIGNED-OFF-fix-5-perlcritic-violations-in-C.patch (text/plain), 2.19 KB, created by
Jonathan Druart
on 2012-07-18 14:10:27 UTC
(
hide
)
Description:
Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/VirtualShelves.pm, and comment-out obselete sub()
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-18 14:10:27 UTC
Size:
2.19 KB
patch
obsolete
>From cb39d7141a2bdab5b390f1581be6f6d59c7c07d3 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 01:58:38 +1200 >Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in > C4/VirtualShelves.pm, and comment-out obselete sub() > >- Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) > >- "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) > >- Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/VirtualShelves.pm | 10 ++++++---- > 1 files changed, 6 insertions(+), 4 deletions(-) > >diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm >index 20f3620..d1db174 100644 >--- a/C4/VirtualShelves.pm >+++ b/C4/VirtualShelves.pm >@@ -221,7 +221,7 @@ Returns the above-mentioned fields for passed virtual shelf number. > > =cut > >-sub GetShelf ($) { >+sub GetShelf { > my ($shelfnumber) = @_; > my $query = qq( > SELECT shelfnumber, shelfname, owner, category, sortfield, >@@ -252,7 +252,7 @@ from C4::Circulation. > > =cut > >-sub GetShelfContents ($;$$$) { >+sub GetShelfContents { > my ($shelfnumber, $row_count, $offset, $sortfield) = @_; > my $dbh=C4::Context->dbh(); > my $sth1 = $dbh->prepare("SELECT count(*) FROM virtualshelfcontents WHERE shelfnumber = ?"); >@@ -351,7 +351,7 @@ sub AddToShelf { > my $sth = $dbh->prepare($query); > > $sth->execute( $shelfnumber, $biblionumber ); >- ($sth->rows) and return undef; # already on shelf >+ ($sth->rows) and return; # already on shelf > $query = qq( > INSERT INTO virtualshelfcontents > (shelfnumber, biblionumber, flags, borrowernumber) >@@ -658,7 +658,8 @@ sub _biblionumber_sth { #only used in obsolete sub below > $sth; > } > >-sub each_biblionumbers (&$) { #OBSOLETE >+=c >+sub each_biblionumbers { #OBSOLETE > my ($code,$shelf) = @_; > my $ref = _biblionumber_sth($shelf)->fetchall_arrayref; > map { >@@ -666,6 +667,7 @@ sub each_biblionumbers (&$) { #OBSOLETE > $code->(); > } @$ref; > } >+=cut > > sub _CheckShelfName { > my ($name, $cat, $owner, $number)= @_; >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208