Attachment 109740 Details for Bug 22343 – Bug 22343: (QA follow-up) Fix some comments

[patch] Bug 22343: (QA follow-up) Fix some comments

Bug-22343-QA-follow-up-Fix-some-comments.patch (text/plain), 1.44 KB, created by Martin Renvoize (ashimema) on 2020-09-08 08:53:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-09-08 08:53:18 UTC

Size: 1.44 KB

patch

obsolete

>From 331244a53b661406872f41da330f38d0f2c1b2e0 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 8 Sep 2020 09:38:45 +0100
>Subject: [PATCH] Bug 22343: (QA follow-up) Fix some comments
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> C4/Letters.pm   | 2 +-
> Koha/Library.pm | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/C4/Letters.pm b/C4/Letters.pm
>index 6981e95732..2bae52d346 100644
>--- a/C4/Letters.pm
>+++ b/C4/Letters.pm
>@@ -1363,7 +1363,7 @@ sub _send_message_by_email {
>     }
> 
> # if initial message address was empty, coming here means that a to address was found and
>-# queue should be updated; same if to address was overriden by create_message_headers
>+# queue should be updated; same if to address was overriden by Koha::Email->create
>     _update_message_to_address( $message->{'message_id'}, $email->email->header('To') )
>       if !$message->{to_address}
>       || $message->{to_address} ne $email->email->header('To');
>diff --git a/Koha/Library.pm b/Koha/Library.pm
>index 7a640d7b74..165d974f44 100644
>--- a/Koha/Library.pm
>+++ b/Koha/Library.pm
>@@ -105,8 +105,6 @@ sub smtp_server {
>     else {
>         # Getter
>         if ( $library_smtp_server_rs ) {
>-            # use Data::Printer colored => 1;
>-            # p($library_smtp_server_rs);
>             return Koha::SMTP::Servers->find(
>                 $library_smtp_server_rs->smtp_server_id );
>         }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22343: 107598 | 107599 | 107600 | 107601 | 107602 | 107603 | 107604 | 107605 | 107987 | 107988 | 107989 | 107990 | 107991 | 107992 | 107993 | 107994 | 107995 | 107996 | 107997 | 107998 | 107999 | 108009 | 108107 | 108108 | 108109 | 108110 | 108111 | 108112 | 108113 | 108114 | 108115 | 108116 | 108117 | 108118 | 108119 | 108131 | 108132 | 108133 | 108134 | 108135 | 108136 | 108137 | 108138 | 108139 | 108140 | 108141 | 108142 | 108143 | 108529 | 108537 | 108538 | 108539 | 108540 | 108541 | 108542 | 108543 | 108544 | 108545 | 108546 | 108547 | 108548 | 108549 | 108609 | 108638 | 108642 | 108643 | 108644 | 108645 | 108646 | 108647 | 108648 | 108649 | 108650 | 108651 | 108652 | 108653 | 108654 | 108655 | 108656 | 108715 | 108716 | 109003 | 109004 | 109005 | 109006 | 109007 | 109008 | 109009 | 109010 | 109011 | 109012 | 109013 | 109014 | 109015 | 109016 | 109017 | 109018 | 109155 | 109156 | 109157 | 109158 | 109159 | 109160 | 109161 | 109162 | 109163 | 109164 | 109165 | 109166 | 109167 | 109168 | 109169 | 109170 | 109601 | 109602 | 109603 | 109604 | 109605 | 109606 | 109607 | 109608 | 109609 | 109610 | 109611 | 109612 | 109613 | 109614 | 109615 | 109616 | 109723 | 109724 | 109725 | 109726 | 109727 | 109728 | 109729 | 109730 | 109731 | 109732 | 109733 | 109734 | 109735 | 109736 | 109737 | 109738 | 109739 | 109740 | 109787 | 109788 | 111048 | 111087 | 111088 | 111089 | 111090 | 111154 | 111165 | 111166 | 111175 | 111176 | 111213 | 111215 | 111216 | 111442 | 111482 | 113240 | 113827 | 113847