Attachment 109755 Details for Bug 25969 – Bug 25969: Checking in a found hold at a different branch then confirming the hold causes internal server error

[patch] Bug 25969: Checking in a found hold at a different branch then confirming the hold causes internal server error

Bug-25969-Checking-in-a-found-hold-at-a-different-.patch (text/plain), 2.62 KB, created by Andrew Fuerste-Henry on 2020-09-08 15:15:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Fuerste-Henry

Created: 2020-09-08 15:15:12 UTC

Size: 2.62 KB

patch

obsolete

>From 05312fffb7378dad93cf4b637b5104a39c355377 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Thu, 9 Jul 2020 14:36:31 -0400
>Subject: [PATCH] Bug 25969: Checking in a found hold at a different branch
> then confirming the hold causes internal server error
>
>If a record level hold is filled and waiting at Library A, and the item
>is checked in at Library B, and an attempt is made to re-fill the hold
>with the item, Koha will return an ISE.
>
>Test Plan:
>1) Place a hold for Library A, at Library A, for pickup at Library A
>2) Check in the item at Library A and fill the hold so it is waiting at Library A
>3) Log in as Library B, check in the same barcode
>4) Note the request to fill the hold with the item
>5) Choose to fill the hold
>6) Note you get an internal server error
>7) Apply this patch
>8) Restart all the things!
>9) Repeat steps 1-5
>10) No ISE!
>
>Signed-off-by: Daniel Gaghan <daniel.gaghan@pueblolibrary.org>
>---
> circ/returns.pl | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/circ/returns.pl b/circ/returns.pl
>index 18c36dd724..4ffea1ed8b 100755
>--- a/circ/returns.pl
>+++ b/circ/returns.pl
>@@ -416,19 +416,22 @@ if ( $messages->{'ResFound'}) {
>         my $diffBranchSend = !$branchCheck ? $reserve->{branchcode} : undef;
>         ModReserveAffect( $reserve->{itemnumber}, $reserve->{borrowernumber}, $diffBranchSend, $reserve->{reserve_id} );
>         my ( $messages, $nextreservinfo ) = GetOtherReserves($reserve->{itemnumber});
>+
>         $template->param(
>             hold_auto_filled => 1,
>             print_slip       => C4::Context->preference('HoldsAutoFillPrintSlip'),
>             reserve_id       => $nextreservinfo->{reserve_id},
>+            itemnumber       => $itemnumber,
>         );
> 
>         if ( $messages->{'transfert'} ) {
>             $template->param(
>-                itemtitle      => $biblio->title,
>-                itemnumber     => $item->itemnumber,
>+                itemtitle        => $biblio->title,
>+                itemnumber       => $item->itemnumber,
>                 itembiblionumber => $biblio->biblionumber,
>-                iteminfo       => $biblio->author,
>-                diffbranch     => 1,
>+                iteminfo         => $biblio->author,
>+                diffbranch       => 1,
>+                itemnumber       => $itemnumber,
>             );
>         }
>     }
>@@ -443,6 +446,7 @@ if ( $messages->{'ResFound'}) {
>                 transfertodo => $branchCheck ? undef : 1,
>                 reserve_id   => $reserve->{reserve_id},
>                 reserved     => 1,
>+                itemnumber   => $itemnumber,
>             );
>         }
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 25969: 106758 | 106771 | 107697 | 109678 | 109755 | 109756 | 110006 | 110007 | 111328 | 111344