Attachment 109792 Details for Bug 16314 – Bug 16314: Show upload link for upload plugin in basic MARC editor

[patch] Bug 16314: Show upload link for upload plugin in basic MARC editor

Bug-16314-Show-upload-link-for-upload-plugin-in-ba.patch (text/plain), 4.85 KB, created by Martin Renvoize (ashimema) on 2020-09-09 12:21:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-09-09 12:21:06 UTC

Size: 4.85 KB

patch

obsolete

>From ea3f155404af88eba788918f7609ea6c7ef512e0 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Sat, 11 Jul 2020 13:25:11 +0000
>Subject: [PATCH] Bug 16314: Show upload link for upload plugin in basic MARC
> editor
>
>This patch updates the basic MARC editor to provide a plugin name
>variable to the template, allowing us to make a check on the name and
>conditionally show an upload link if the "upload.pl" cataloging plugin
>is selected.
>
>To test, apply the patch and rebuild the staff client CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
>
> - Go do Administration -> MARC bibliographic framework -> MARC
> structure -> 856 -> Edit subfields.
> - Edit the "u" subfield and select "upload.pl" as the plugin under
> "Other options."
> - Go to Cataloging and create or edit a MARC record.
> - Under tab 8 look for the 856 tag, subfield u. There should be an
> "Upload" link corresponding to the form field.
> - Click the upload link to confirm that it triggers a popup window with
> the upload form.
> - Confirm that other similar plugin links (for instance 100$a, 600$a)
> display the old "tag editor" icon.
>
>Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> cataloguing/addbiblio.pl | 1 +
> cataloguing/value_builder/upload.pl | 1 +
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 9 +++++++++
> .../prog/en/modules/cataloguing/addbiblio.tt | 6 +++++-
> 4 files changed, 16 insertions(+), 1 deletion(-)
>
>diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
>index e5c33dcfd8..996f61112b 100755
>--- a/cataloguing/addbiblio.pl
>+++ b/cataloguing/addbiblio.pl
>@@ -395,6 +395,7 @@ sub create_input {
> size => 67,
> maxlength => $subfield_data{maxlength},
> javascript => $plugin->javascript,
>+ plugin => $plugin->name,
> noclick => $plugin->noclick,
> };
> } else {
>diff --git a/cataloguing/value_builder/upload.pl b/cataloguing/value_builder/upload.pl
>index e26bca7f99..85c6bc656e 100755
>--- a/cataloguing/value_builder/upload.pl
>+++ b/cataloguing/value_builder/upload.pl
>@@ -35,6 +35,7 @@ my $builder = sub {
> return <<"SCRIPT";
> <script type=\"text/javascript\">
> function Click$params->{id}(event) {
>+ event.preventDefault();
> var index = event.data.id;
> var str = document.getElementById(index).value;
> var myurl, term;
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index 64f79cd349..9a7470546e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -3455,6 +3455,15 @@ progress {
> text-indent: 100%;
> white-space: nowrap;
> width: 16px;
>+
>+ &.upload {
>+ background: transparent none;
>+ font-size: 90%;
>+ height: unset;
>+ overflow: unset;
>+ text-indent: unset;
>+ width: unset;
>+ }
> }
> 
> .browse-controls {
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 4f4fc5901c..70dbd7e5a9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -840,7 +840,11 @@
> [% IF mv.noclick %]
> 
> [% ELSE %]
>- <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>
>+ [% IF mv.plugin == "upload.pl" %]
>+ <a href="#" id="buttonDot_[% mv.id | html %]" class="tag_editor upload framework_plugin" tabindex="1"> Upload</a>
>+ [% ELSE %]
>+ <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>
>+ [% END %]
> [% END %]
> 
> [% mv.javascript | $raw %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 16314: 106784 | 109561 | 109792