Bugzilla – Attachment 10980 Details for
Bug 6679
Fixing code so it passes basic Perl::Critic tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm
0001-Bug-6679-SIGNED-OFF-fix-2-perlcritic-violations-in-C.patch (text/plain), 1.96 KB, created by
Jonathan Druart
on 2012-07-18 14:21:40 UTC
(
hide
)
Description:
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2012-07-18 14:21:40 UTC
Size:
1.96 KB
patch
obsolete
>From 1a7da7192a6569f3ac04797ad9a26da05e46daba Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Wed, 27 Jun 2012 05:02:00 +1200 >Subject: [PATCH 1/1] Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in > C4/Print.pm > >Bareword file handle opened at line 80, column 9. See pages 202,204 of PBP. (Severity: 5) > >Two-argument "open" used at line 80, column 9. See page 207 of PBP. (Severity: 5) > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > >http://perldoc.perl.org/functions/open.html >For three or more arguments if MODE is |- , the filename is interpreted >as a command to which output is to be piped, and if MODE is -| , the >filename is interpreted as a command that pipes output to us. I >--- > C4/Print.pm | 12 +++++++----- > 1 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/C4/Print.pm b/C4/Print.pm >index 12aa107..6683119 100644 >--- a/C4/Print.pm >+++ b/C4/Print.pm >@@ -67,9 +67,11 @@ sub NetworkPrint { > # set the queue to "file" (or " file", if real queues aren't allowed > # to have spaces in them). Or perhaps if $queue eq "" and > # $env->{file} ne "", then that should mean "print to $env->{file}". >+ >+ my $fh; > if ( $queue eq "" || $queue eq 'nulllp' ) { > return; >- #open( PRINTER, ">/tmp/kohaiss" ); >+ #open( $fh, ">/tmp/kohaiss" ); > } > else { > >@@ -77,15 +79,15 @@ sub NetworkPrint { > # This is a reasonable assumption, but only because every other > # printing package has a wrapper script called 'lpr'. It'd still > # be better to be able to customize this. >- open( PRINTER, "| lpr -P $queue > /dev/null" ) >+ open( $fh, "-|", "lpr -P $queue > /dev/null" ) > or die "Couldn't write to queue:$queue!\n"; > } > > # print $queue; > #open (FILE,">/tmp/$file"); >- print PRINTER $text; >- print PRINTER "\r\n" x 7 ; >- close PRINTER; >+ print $fh $text; >+ print $fh "\r\n" x 7 ; >+ close $fh; > > #system("lpr /tmp/$file"); > } >-- >1.7.7.3 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6679
:
4883
|
4884
|
4885
|
4886
|
4887
|
4888
|
5445
|
5446
|
5483
|
5487
|
6121
|
6122
|
6123
|
6139
|
6140
|
6141
|
6142
|
6143
|
6144
|
6270
|
6271
|
6663
|
6670
|
6675
|
6676
|
6677
|
6678
|
8542
|
8897
|
8898
|
8899
|
8950
|
8951
|
9746
|
9747
|
9748
|
9749
|
9750
|
10050
|
10051
|
10052
|
10053
|
10054
|
10075
|
10076
|
10077
|
10078
|
10079
|
10484
|
10485
|
10486
|
10487
|
10488
|
10489
|
10491
|
10492
|
10493
|
10494
|
10495
|
10496
|
10497
|
10499
|
10500
|
10501
|
10502
|
10503
|
10504
|
10505
|
10506
|
10507
|
10508
|
10509
|
10510
|
10512
|
10513
|
10514
|
10515
|
10517
|
10521
|
10522
|
10523
|
10524
|
10525
|
10526
|
10527
|
10935
|
10936
|
10938
|
10940
|
10944
|
10945
|
10946
|
10947
|
10948
|
10949
|
10950
|
10952
|
10953
|
10955
|
10957
|
10958
|
10959
|
10960
|
10961
|
10962
|
10963
|
10964
|
10965
|
10966
|
10967
|
10972
|
10976
|
10979
|
10980
|
10981
|
12224
|
12363
|
12490
|
12491
|
12492
|
34191
|
34192
|
34193
|
34194
|
34195
|
34196
|
34197
|
39100
|
39101
|
39102
|
39392
|
39393
|
39394
|
39395
|
39396
|
39397
|
39398
|
42770
|
47086
|
47087
|
47088
|
47089
|
47090
|
47178
|
47179
|
47180
|
47181
|
47205
|
47206
|
47207
|
47208