Bugzilla – Attachment 109823 Details for
Bug 26364
XISBN.t makes a bad assumption about return values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26364: Remove useless condition
Bug-26364-Remove-useless-condition.patch (text/plain), 925 bytes, created by
Nick Clemens (kidclamp)
on 2020-09-09 14:37:00 UTC
(
hide
)
Description:
Bug 26364: Remove useless condition
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-09-09 14:37:00 UTC
Size:
925 bytes
patch
obsolete
>From ff360ffea96b67a980f89580a5048549db18c045 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 9 Sep 2020 13:40:37 +0000 >Subject: [PATCH] Bug 26364: Remove useless condition > >$response_data is a hash with one key, content > >Why are we checkiing it against a string? >--- > C4/XISBN.pm | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/C4/XISBN.pm b/C4/XISBN.pm >index 6f7c3bf4bc..68b7c0f8d1 100644 >--- a/C4/XISBN.pm >+++ b/C4/XISBN.pm >@@ -102,7 +102,6 @@ sub get_xisbns { > # loop through each ISBN and scope to the local collection > for my $response_data( @{ $response->{ isbn } } ) { > next if $response_data->{'content'} eq $isbn; >- next if $isbn eq $response_data; > next if $unique_xisbns->{ $response_data->{content} }; > $unique_xisbns->{ $response_data->{content} }++; > my $xbiblio= _get_biblio_from_xisbn($response_data->{content}); >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=109823">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26364
:
109599
|
109631
|
109821
|
109822
|
109823
|
109824
|
109825
|
113054
|
113055
|
113056
|
113057
|
113058
|
114818
|
114819
|
114820
|
114821
|
114822