Attachment 109824 Details for Bug 26364 – Bug 26364: Don't discard the passed isbn

[patch] Bug 26364: Don't discard the passed isbn

Bug-26364-Dont-discard-the-passed-isbn.patch (text/plain), 1.00 KB, created by Nick Clemens (kidclamp) on 2020-09-09 14:37:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-09-09 14:37:03 UTC

Size: 1.00 KB

patch

obsolete

>From 03a9b4e3105a5171db1504e68a7caa1d11c52f97 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 9 Sep 2020 13:44:45 +0000
>Subject: [PATCH] Bug 26364: Don't discard the passed isbn
>
>I don't know, if we get rid fo this check we can now check the db for the same isbn we passed
>
>This may be useful as we may want to see the biblio with the same isbn as long as number is different?
>
>This will make tests fail
>---
> C4/XISBN.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/XISBN.pm b/C4/XISBN.pm
>index 68b7c0f8d1..65ef2878db 100644
>--- a/C4/XISBN.pm
>+++ b/C4/XISBN.pm
>@@ -101,7 +101,6 @@ sub get_xisbns {
> 
>     # loop through each ISBN and scope to the local collection
>     for my $response_data( @{ $response->{ isbn } } ) {
>-        next if $response_data->{'content'} eq $isbn;
>         next if $unique_xisbns->{ $response_data->{content} };
>         $unique_xisbns->{ $response_data->{content} }++;
>         my $xbiblio= _get_biblio_from_xisbn($response_data->{content});
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26364: 109599 | 109631 | 109821 | 109822 | 109823 | 109824 | 109825 | 113054 | 113055 | 113056 | 113057 | 113058 | 114818 | 114819 | 114820 | 114821 | 114822