Bugzilla – Attachment 109834 Details for
Bug 23816
Allow to have different password strength and length settings for different patron categories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23816: Fix selenium tests
Bug-23816-Fix-selenium-tests.patch (text/plain), 2.78 KB, created by
Jonathan Druart
on 2020-09-10 08:07:21 UTC
(
hide
)
Description:
Bug 23816: Fix selenium tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-09-10 08:07:21 UTC
Size:
2.78 KB
patch
obsolete
>From 4405083a42fce37aad6de51e24c9ef65513d4001 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 10 Sep 2020 10:07:05 +0200 >Subject: [PATCH] Bug 23816: Fix selenium tests > >--- > t/db_dependent/selenium/authentication.t | 4 ++-- > t/db_dependent/selenium/regressions.t | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/selenium/authentication.t b/t/db_dependent/selenium/authentication.t >index 9ea90e3d8c..591fb09d07 100644 >--- a/t/db_dependent/selenium/authentication.t >+++ b/t/db_dependent/selenium/authentication.t >@@ -47,8 +47,8 @@ SKIP: { > $driver->get($mainpage); > like( $driver->get_title, qr(Log in to Koha), 'Hitting the main page should redirect to the login form'); > >- my $password = Koha::AuthUtils::generate_password(); > my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0 }}); >+ my $password = Koha::AuthUtils::generate_password($patron->category); > t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 ); > $patron->set_password({ password => $password }); > >@@ -81,8 +81,8 @@ SKIP: { > $driver->get($mainpage); > like( $driver->get_title, qr(Koha online catalog), 'Hitting the main page should not redirect to the login form'); > >- my $password = Koha::AuthUtils::generate_password(); > my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0 }}); >+ my $password = Koha::AuthUtils::generate_password($patron->category); > t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 ); > $patron->set_password({ password => $password }); > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 45517a5a45..98fcf091e5 100644 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -54,7 +54,7 @@ subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub { > > my $patron = $builder->build_object( > { class => 'Koha::Patrons', value => { flags => 1 } } ); >- my $password = Koha::AuthUtils::generate_password(); >+ my $password = Koha::AuthUtils::generate_password($patron->category); > t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 ); > $patron->set_password({ password => $password }); > $s->opac_auth( $patron->userid, $password ); >@@ -205,7 +205,7 @@ subtest 'XSS vulnerabilities in pagination' => sub { > ); > } > >- my $password = Koha::AuthUtils::generate_password(); >+ my $password = Koha::AuthUtils::generate_password($patron->category); > t::lib::Mocks::mock_preference( 'RequireStrongPassword', 0 ); > $patron->set_password({ password => $password }); > $s->opac_auth( $patron->userid, $password ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23816
:
103099
|
103100
|
103101
|
103102
|
103103
|
103104
|
103108
|
103109
|
103110
|
103111
|
103112
|
103113
|
103805
|
103806
|
103807
|
103808
|
103809
|
103810
|
107158
|
107159
|
107160
|
107161
|
107162
|
107163
|
108554
|
108555
|
108556
|
108557
|
108558
|
108559
|
108571
|
108572
|
109243
|
109244
|
109245
|
109249
|
109250
|
109251
|
109252
|
109253
|
109254
|
109255
|
109256
|
109257
|
109520
|
109521
|
109522
|
109523
|
109524
|
109525
|
109526
|
109527
|
109528
|
109833
| 109834