Bugzilla – Attachment 109942 Details for
Bug 26407
fix query in 'title exists' in `search_for_data_inconsistencies.pl`
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26407: fix query in 'title exists' in `search_for_data_inconsistencies.pl`
Bug-26407-fix-query-in-title-exists-in-searchforda.patch (text/plain), 1.62 KB, created by
Nick Clemens (kidclamp)
on 2020-09-11 13:26:49 UTC
(
hide
)
Description:
Bug 26407: fix query in 'title exists' in `search_for_data_inconsistencies.pl`
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-09-11 13:26:49 UTC
Size:
1.62 KB
patch
obsolete
>From d43592af13371944ef5556eb8dc3cebe7efc9321 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 8 Sep 2020 16:54:19 +0200 >Subject: [PATCH] Bug 26407: fix query in 'title exists' in > `search_for_data_inconsistencies.pl` > >Bug 23871 added check for 'title exists' to `search_for_data_inconsistencies.pl`. >There is a typo in DBIx query to create or : hashref instead of arrayref. > >Test plan : >1) Change title of biblio record XXX in SQL : > UPDATE biblio SET title = '' WHERE biblionumber=XXX >2) Change title of biblio record YYY in SQL : > UPDATE biblio SET title = NULL WHERE biblionumber=YYY >3) Run misc/maintenance/search_for_data_inconsistencies.pl >4) Check you see both records > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > misc/maintenance/search_for_data_inconsistencies.pl | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl >index 8f4014529e..433f668040 100755 >--- a/misc/maintenance/search_for_data_inconsistencies.pl >+++ b/misc/maintenance/search_for_data_inconsistencies.pl >@@ -196,7 +196,12 @@ use C4::Biblio; > } > > { >- my $biblios = Koha::Biblios->search({ -or => { title => undef, title => '' }}); >+ my $biblios = Koha::Biblios->search({ >+ -or => [ >+ title => '', >+ title => undef, >+ ] >+ }); > if ( $biblios->count ) { > my ( $title_tag, $title_subtag ) = C4::Biblio::GetMarcFromKohaField( 'biblio.title' ); > my $title_field = $title_tag // ''; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26407
:
109754
|
109763
| 109942