Attachment 109991 Details for Bug 26299 – Bug 26299: Use same SMS number help text in OPAC as staff interface

[patch] Bug 26299: Use same SMS number help text in OPAC as staff interface

Bug-26299-Use-same-SMS-number-help-text-in-OPAC-as.patch (text/plain), 3.35 KB, created by Katrin Fischer on 2020-09-12 18:46:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-09-12 18:46:00 UTC

Size: 3.35 KB

patch

obsolete

>From a0c5a53e2ab8f3a1244fcf5973e10d3ef8989c67 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 3 Sep 2020 13:25:45 +0000
>Subject: [PATCH] Bug 26299: Use same SMS number help text in OPAC as staff
> interface
>
>The SMS number help text in the OPAC follows a North American phone
>number style. It should be more generic. To that end, this patch
>makes the OPAC use the same help text for SMS numbers as
>the staff interface
>
>To test:
>1) Apply the patch
>2) Set "SMSSendDriver" to "Anything" in global system preferences
>3) Go to the following link and note the help text by SMS number
>http://localhost:8081/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=51
>4) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl
>5) Note that the help text in both interfaces uses the same wording
>
>Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt        | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index f0c235b7c6..9e8dda2518 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -1416,7 +1416,7 @@ legend:hover {
>                                             <p>
>                                                 <label for="SMSnumber">SMS number:</label>
>                                                 <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" />
>-                                                <span class="hint">SMS number should be in the format 1234567890 or +11234567890</span>
>+                                                <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + if including the country code.</span>
>                                             </p>
>                                             [% UNLESS nosms_provider_id %]
>                                                 <p>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 3d3192fc6b..a2122b70fe 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -147,7 +147,7 @@
>                                             <li>
>                                                 <label for="SMSnumber">SMS number:</label>
>                                                 <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^(\+[1-9]\d{0,2})?\d{1,12}$" />
>-                                                <div class="hint">Please enter numbers only. <strong>(123) 456-7890</strong> would be entered as <strong>1234567890</strong>.</div>
>+                                                <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + if including the country code.</span>
>                                             </li>
> 
>                                             [% IF ( SMSSendDriver == 'Email' ) %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26299: 109136 | 109183 | 109191 | 109625 | 109667 | 109991