Bugzilla – Attachment 110091 Details for
Bug 24718
Introduce hour-based holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24718: (follow-up) Update syspref description, fix expdate time when setting waiting
Bug-24718-follow-up-Update-syspref-description-fix.patch (text/plain), 2.17 KB, created by
Aleisha Amohia
on 2020-09-15 01:59:58 UTC
(
hide
)
Description:
Bug 24718: (follow-up) Update syspref description, fix expdate time when setting waiting
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2020-09-15 01:59:58 UTC
Size:
2.17 KB
patch
obsolete
>From dcd2db849ed6cefeaf05a14e8ebd81f6239cf344 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 15 Sep 2020 13:56:02 +1200 >Subject: [PATCH] Bug 24718: (follow-up) Update syspref description, fix > expdate time when setting waiting > >--- > Koha/Hold.pm | 2 +- > .../intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Hold.pm b/Koha/Hold.pm >index 360b43e7b5..463730395f 100644 >--- a/Koha/Hold.pm >+++ b/Koha/Hold.pm >@@ -201,7 +201,7 @@ sub set_waiting { > # If patron's requested expiration date is prior to the > # calculated one, we keep the patron's one. > my $cmp = $requested_expiration ? DateTime->compare($requested_expiration, $expirationdate) : 0; >- $values->{expirationdate} = $cmp == -1 ? $requested_expiration->ymd : $expirationdate->ymd; >+ $values->{expirationdate} = $cmp == -1 ? $requested_expiration : $expirationdate; > > $self->set($values)->store(); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index 3fa27f7d00..7421e3ea9a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -632,7 +632,7 @@ Circulation: > choices: > yes: Allow > no: "Don't allow" >- - holds to operate on an hourly or minutes basis. If enabled, hours and minutes will be considered when placing a hold, and cronjobs will be run hourly. >+ - holds to operate on an hourly or minutes basis. If enabled, hours and minutes will be considered when placing a hold, and the relevant cronjob should be enabled to run hourly.<br><strong>NOTE:</strong> This system preference requires the <code>misc/cronjobs/holds/*</code> cronjobs to run hourly. Ask your system administrator to schedule them. > - > - In the staff interface, split the holds queue into separate tables by > - pref: HoldsSplitQueue >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24718
:
99540
|
99541
|
99542
|
99543
|
99544
|
99545
|
99548
|
103521
|
103522
|
103549
|
103550
|
103551
|
103552
|
103553
|
103554
|
103555
|
106270
|
106271
|
106272
|
106273
|
106274
|
106275
|
110084
|
110085
|
110086
|
110087
|
110088
|
110089
|
110090
|
110091
|
110098
|
110137
|
110161
|
110303
|
126559
|
126560
|
126561
|
126562
|
126563
|
126564
|
148293
|
148294
|
148295
|
148296
|
148297
|
148298
|
162474
|
162475
|
162476
|
162477
|
162478
|
162479