Attachment 110117 Details for Bug 26421 – Bug 26421: Use Bootstrap screen reader text class for shelf browser messages

[patch] Bug 26421: Use Bootstrap screen reader text class for shelf browser messages

Bug-26421-Use-Bootstrap-screen-reader-text-class-f.patch (text/plain), 4.06 KB, created by Katrin Fischer on 2020-09-15 18:57:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-09-15 18:57:24 UTC

Size: 4.06 KB

patch

obsolete

>From b714c23413bf2470ff0489807dcef94ef304ab74 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 9 Sep 2020 15:58:04 +0000
>Subject: [PATCH] Bug 26421: Use Bootstrap screen reader text class for shelf
> browser messages
>
>This patch udpates the markup added by Bug 26039, replacing the "hidden"
>class, which is no longer functional with Bootstrap 4, with "sr-only," a
>class designed specifically for screen reader text.
>
>The patch also corrects a typo, "shelfbrowers" -> "shelf browser"
>
>To test, apply the patch and make sure the OPACShelfBrowser system
>preference is enabled.
>
>View the detail page for a bibliographic record with items. In the
>holdings table, you should see links labeled "Browse shelf."
>
>When you open the shelf browser there should be a link at the top that
>reads "Close shelf browser."
>
>If you have access to a screen reader, test that the hidden text is
>announced by the reader. "Browse shelf (Opens below)" and "Close shelf
>browser (Hides shelf browser)."
>
>Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
>index 253fe20893..396470d977 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
>@@ -7,7 +7,7 @@
> [%- IF ( starting_location ) %]Shelving location: [%- starting_location | html -%][% END -%]
> [%- IF ( starting_homebranch && starting_ccode ) %], [% END %]
> [%- IF ( starting_ccode ) %]Collection: [%- starting_ccode | html -%][% END -%]
>- <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf" >Close shelf browser (Hides shelfbrowers)</a>
>+ <a style="font-size: 75%;" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | html %]" class="close_shelf" >Close shelf browser (Hides shelf browser)</a>
> </h5>
> 
> <table class="table">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>index 44104e1f7b..2854660887 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
>@@ -1331,9 +1331,9 @@
> [% ITEM_RESULT.itemcallnumber | html %]
> [% IF ( OPACShelfBrowser ) %]
> [% IF ( ITEM_RESULT.itemnumber == starting_itemnumber ) %]
>- (<a class="close_shelf" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | html %]&amp;shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | html %]#[% tab | html %]">Browse shelf (Opens below)</a>)
>+ (<a class="close_shelf" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | html %]&amp;shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | html %]#[% tab | html %]">Browse shelf (Opens below)</a>)
> [% ELSE %]
>- (<a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | uri %]&amp;shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | uri %]#[% tab | uri %]">Browse shelf (Opens below)</a>)
>+ (<a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber | uri %]&amp;shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber | uri %]#[% tab | uri %]">Browse shelf (Opens below)</a>)
> [% END %]
> [% END %]
> [% END %]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26421: 109829 | 110058 | 110117