Bugzilla – Attachment 110183 Details for
Bug 26460
Wrong line ending (semicolon vs comma) in request.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26460: Fix line ending in JSON
Bug-26460-Fix-line-ending-in-JSON.patch (text/plain), 1.68 KB, created by
David Nind
on 2020-09-16 12:11:45 UTC
(
hide
)
Description:
Bug 26460: Fix line ending in JSON
Filename:
MIME Type:
Creator:
David Nind
Created:
2020-09-16 12:11:45 UTC
Size:
1.68 KB
patch
obsolete
>From e6dc5961e041b6ba973d0cdae916c89c2538672d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 14 Sep 2020 17:44:36 +0000 >Subject: [PATCH] Bug 26460: Fix line ending in JSON > >Wrong line ending in JSON causes error: >Uncaught SyntaxError: missing } after property list >note: { opened at line 29579, column 15 > >To test: >1 - Have a title with some items not for hold in staff interface >2 - Set AllowHoldPolicyOverride to 'Allow' >3 - Attempt to place hold on the title >4 - Note JS error in the console and datatable does not load for items >5 - Apply patch >6 - Reload >7 - Error is cleared, table loads correctly > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 984a71c415..642b3d776f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -992,7 +992,7 @@ > var patron_homebranch = "[% To.json( Branches.GetName( patron.branchcode ) ) | $raw %]"; > var override_items = {[% FOREACH bibitemloo IN bibitemloop %][% FOREACH itemloo IN bibitemloo.itemloop %][% IF ( itemloo.override ) %] > [% itemloo.itemnumber | html %]: { >- homebranch: "[% To.json( Branches.GetName( itemloo.homebranch ) ) | $raw %]"; >+ homebranch: "[% To.json( Branches.GetName( itemloo.homebranch ) ) | $raw %]", > holdallowed: [% itemloo.holdallowed | html %] > }, > [% END %][% END %][% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26460
:
110072
|
110183
|
110231