Bugzilla – Attachment 11026 Details for
Bug 8418
Koha::Calendar is_holiday ignores all user data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays
Bug-8418---KohaCalendar-isholiday-ignores-repeatin.patch (text/plain), 1.35 KB, created by
Kyle M Hall (khall)
on 2012-07-19 18:36:25 UTC
(
hide
)
Description:
Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-07-19 18:36:25 UTC
Size:
1.35 KB
patch
obsolete
>From 735aba1f615ef261d6d6af2471cb906b64b95d8f Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Wed, 11 Jul 2012 14:32:35 +0200 >Subject: [PATCH] Bug 8418 - Koha::Calendar is_holiday ignores repeating holidays > >This is simple fix since day_month_closed_days hash has wrong arguments >order and it's not used outside Koha::Calenar code. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Calendar.pm | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm >index 495f8ce..2435a7f 100644 >--- a/Koha/Calendar.pm >+++ b/Koha/Calendar.pm >@@ -150,7 +150,7 @@ sub is_holiday { > $dt->truncate( to => 'day' ); > my $day = $dt->day; > my $month = $dt->month; >- if ( exists $self->{day_month_closed_days}->{$month}->{$day} ) { >+ if ( exists $self->{day_month_closed_days}->{$day}->{$month} ) { > return 1; > } > if ( $self->{exception_holidays}->contains($dt) ) { >@@ -208,7 +208,7 @@ sub hours_between { > sub _mockinit { > my $self = shift; > $self->{weekly_closed_days} = [ 1, 0, 0, 0, 0, 0, 0 ]; # Sunday only >- $self->{day_month_closed_days} = { 6 => { 16 => 1, } }; >+ $self->{day_month_closed_days} = { 16 => { 6 => 1, } }; > my $dates = []; > $self->{exception_holidays} = > DateTime::Set->from_datetimes( dates => $dates ); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8418
:
10769
|
10770
|
10773
|
10774
|
10810
|
10811
|
10838
|
10839
|
10840
|
11025
|
11026
|
11611
|
11624