Attachment 110261 Details for Bug 25539 – Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script

[patch] Bug 25539: Strip items when adding new biblio to preserve previous behaviour of the script

Bug-25539-Strip-items-when-adding-new-biblio-to-pr.patch (text/plain), 1.71 KB, created by David Gustafsson on 2020-09-17 12:13:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Gustafsson

Created: 2020-09-17 12:13:09 UTC

Size: 1.71 KB

patch

obsolete

>From 56771ebfcd538a4ffabe940febe923f3a3bbe1b1 Mon Sep 17 00:00:00 2001
>From: David Gustafsson <glasklas@gmail.com>
>Date: Thu, 17 Sep 2020 14:10:51 +0200
>Subject: [PATCH] Bug 25539: Strip items when adding new biblio to preserve
> previous behaviour of the script
>
>---
> misc/migration_tools/bulkmarcimport.pl | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl
>index 5e4702449a..2a8ed01c33 100755
>--- a/misc/migration_tools/bulkmarcimport.pl
>+++ b/misc/migration_tools/bulkmarcimport.pl
>@@ -468,7 +468,15 @@ RECORD: while (  ) {
>                 }
>             } else {
>                 if ($insert) {
>-                    eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record, '') };
>+                    my $record_clone = $record->clone();
>+                    my $_framework = '';
>+                    C4::Biblio::_strip_item_fields($record_clone, $_framework );
>+                    eval { ( $biblionumber, $biblioitemnumber ) = AddBiblio( $record_clone, $_framework ) };
>+                    # If incoming record has bib ids set we need to transfer
>+                    # new ids from record_clone to incoming record to avoid
>+                    # working on wrong record (the original record) later on
>+                    # when adding items for example
>+                    C4::Biblio::_koha_marc_update_bib_ids($record, $_framework, $biblionumber, $biblioitemnumber);
>                     if ($@) {
>                         warn "ERROR: Adding biblio $biblionumber failed: $@\n";
>                         printlog( { id => $id || $originalid || $biblionumber, op => "insert", status => "ERROR" } ) if ($logfile);
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25539: 105065 | 105066 | 109789 | 110260 | 110261 | 127599 | 127600 | 127601 | 127602 | 127603 | 127976 | 127977 | 127978 | 127979 | 127980 | 127981 | 133030 | 133031 | 133032 | 133034 | 133035 | 133036 | 140992 | 140993 | 140994 | 156224 | 156225 | 156226 | 160158 | 160159 | 160160 | 160489 | 160490 | 160491