Attachment 110327 Details for Bug 25261 – Bug 25261: (QA follow-up) Add unit tests

[patch] Bug 25261: (QA follow-up) Add unit tests

Bug-25261-QA-follow-up-Add-unit-tests.patch (text/plain), 2.81 KB, created by Martin Renvoize (ashimema) on 2020-09-18 10:02:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-09-18 10:02:57 UTC

Size: 2.81 KB

patch

obsolete

>From a1abd36ffce9b852113ac7291e97028bc9245310 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 6 May 2020 10:33:35 +0100
>Subject: [PATCH] Bug 25261: (QA follow-up) Add unit tests
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Circulation.t | 53 +++++++++++++++++++++++++++++++++++-
> 1 file changed, 52 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index f26f2f3255..8486caaa69 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -18,7 +18,7 @@
> use Modern::Perl;
> use utf8;
> 
>-use Test::More tests => 48;
>+use Test::More tests => 51;
> use Test::Exception;
> use Test::MockModule;
> use Test::Deep qw( cmp_deeply );
>@@ -3538,6 +3538,57 @@ subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
>     $itemtype->rentalcharge_daily('0')->store;
> };
> 
>+subtest 'CanBookBeIssued & CircConfirmItemParts' => sub {
>+    plan tests => 1;
>+
>+    t::lib::Mocks::mock_preference('CircConfirmItemParts', 1);
>+
>+    my $library =
>+      $builder->build_object( { class => 'Koha::Libraries' } )->store;
>+    my $patron = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { categorycode => $patron_category->{categorycode} }
>+        }
>+    )->store;
>+
>+    my $itemtype = $builder->build_object(
>+        {
>+            class => 'Koha::ItemTypes',
>+            value => {
>+                notforloan         => 0,
>+                rentalcharge       => 0,
>+                rentalcharge_daily => 0
>+            }
>+        }
>+    );
>+
>+    my $biblioitem = $builder->build( { source => 'Biblioitem' } );
>+    my $item = $builder->build_object(
>+        {
>+            class => 'Koha::Items',
>+            value => {
>+                homebranch       => $library->id,
>+                holdingbranch    => $library->id,
>+                notforloan       => 0,
>+                itemlost         => 0,
>+                withdrawn        => 0,
>+                itype            => $itemtype->id,
>+                biblionumber     => $biblioitem->{biblionumber},
>+                biblioitemnumber => $biblioitem->{biblioitemnumber},
>+                materials        => 'includes DVD',
>+            }
>+        }
>+    )->store;
>+
>+    my ( $issuingimpossible, $needsconfirmation );
>+    my $dt_from = dt_from_string();
>+    my $dt_due = $dt_from->clone->add( days => 3 );
>+
>+    ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
>+    is_deeply( $needsconfirmation, { additional_materials => 'includes DVD' }, 'Item needs confirmation of additional parts' );
>+};
>+
> subtest 'Do not return on renewal (LOST charge)' => sub {
>     plan tests => 1;
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25261: 103856 | 103857 | 104011 | 104012 | 104013 | 104404 | 104405 | 104406 | 104407 | 104408 | 104409 | 104410 | 104411 | 104412 | 104413 | 104414 | 107217 | 107218 | 107219 | 107220 | 107221 | 107222 | 107228 | 107229 | 107230 | 107231 | 107232 | 107233 | 107234 | 107285 | 107331 | 107822 | 107823 | 108196 | 108197 | 108198 | 108199 | 108200 | 108201 | 108202 | 108203 | 108204 | 108205 | 108206 | 108207 | 108208 | 108230 | 108231 | 108232 | 108233 | 108234 | 108235 | 108236 | 108237 | 108238 | 108239 | 108240 | 108241 | 108242 | 109478 | 109479 | 109480 | 109481 | 109482 | 109483 | 109484 | 109485 | 109486 | 109487 | 109488 | 109489 | 109490 | 109491 | 109492 | 109493 | 109494 | 109495 | 109496 | 109497 | 109498 | 109499 | 109500 | 109501 | 109502 | 109503 | 109504 | 109508 | 110038 | 110039 | 110040 | 110041 | 110042 | 110043 | 110044 | 110045 | 110046 | 110047 | 110048 | 110049 | 110050 | 110051 | 110052 | 110133 | 110184 | 110258 | 110259 | 110268 | 110322 | 110323 | 110324 | 110325 | 110326 | 110327 | 110328 | 110329 | 110330 | 110331 | 110332 | 110333 | 110334 | 110335 | 110336 | 110337 | 110338 | 110339 | 110340 | 110341 | 110356 | 110357 | 110358 | 110359 | 110360 | 110361 | 110362 | 110363 | 110364 | 110365 | 110366 | 110367 | 110368 | 110369 | 110370 | 110371 | 110372 | 110373 | 110374 | 110375 | 110915 | 110916 | 110917 | 110918 | 110919 | 110920 | 110921 | 110922 | 110923 | 110924 | 110925 | 110926 | 110927 | 110928 | 110929 | 110930 | 110931 | 110932 | 110933 | 110934 | 111027