Bugzilla – Attachment 11045 Details for
Bug 8448
Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
Bug-8448---Holds-Awaiting-Pickup--Cancelling-a-hol.patch (text/plain), 3.46 KB, created by
Marc Véron
on 2012-07-20 13:50:21 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-07-20 13:50:21 UTC
Size:
3.46 KB
patch
obsolete
>From 5e59555a375efe343a2b379d173f4f86ee44a3b2 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 16 Jul 2012 14:13:31 +1000 >Subject: [PATCH] Bug 8448 - Holds Awaiting Pickup : Cancelling a hold on a waiting item with multiple holds displays a blank screen instead of a warning prompt >Content-Type: text/plain; charset="utf-8" > >When you cancel a hold in the "Hold Waiting" tab of Holds Awaiting Pickup, you should be prompted to retain or transfer the hold for the next patron in the queue. However, instead of seeing this prompt, you are just shown white screen that fails to alert you to the fact that there are more holds on that item! > >There is a missing FOREACH reference in waitingreserves.tt. The template tries to directly reference the hash within the cancel_results array, but we need to access the array before we can access the hash. >--- > .../prog/en/modules/circ/waitingreserves.tt | 44 ++++++++++--------- > 1 files changed, 23 insertions(+), 21 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >index 0101d7f..4791038 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt >@@ -45,27 +45,29 @@ $.tablesorter.addParser({ > [% END %] > </h2> > [% IF ( cancel_result ) %] >- [% IF ( cancel_result.messagetransfert ) %] >- <div> >- <h2>Hold find for ([% nextreservtitle %]), must be transferred</h2> >- <p>This hold placed by : <b> [% nextreservsurname %] [% nextreservfirstname %]</b> at the library : <b> [% branchname %] </b>, Please transfer this hold. >- </p> >- <form name="cancelReservewithtransfert" action="waitingreserves.pl" method="post"> >- <input type="submit" class="button" /> >- </form> >- </div> >- [% END %] >- [% IF ( cancel_result.waiting ) %] >- <div id="bloc25"> >- <h2>This hold is waiting</h2> >- <p>This hold ([% nextreservtitle %]) was placed by <b> : [% nextreservsurname %] [% nextreservfirstname %]</b>, >- Please retain this hold. >- </p> >- <form name="cancelReservewithwaiting" action="waitingreserves.pl" method="post"> >- <input type="submit" /> >- </form> >- </div> >- [% END %] >+ [% FOREACH cancel_result %] >+ [% IF ( messagetransfert ) %] >+ <div> >+ <h2>Hold find for ([% nextreservtitle %]), must be transferred</h2> >+ <p>This hold placed by : <b> [% nextreservsurname %] [% nextreservfirstname %]</b> at the library : <b> [% branchname %] </b>, Please transfer this hold. >+ </p> >+ <form name="cancelReservewithtransfert" action="waitingreserves.pl" method="post"> >+ <input type="submit" class="button" /> >+ </form> >+ </div> >+ [% END %] >+ [% IF ( waiting ) %] >+ <div id="bloc25"> >+ <h2>This hold is waiting</h2> >+ <p>This hold ([% nextreservtitle %]) was placed by <b> : [% nextreservsurname %] [% nextreservfirstname %]</b>, >+ Please retain this hold. >+ </p> >+ <form name="cancelReservewithwaiting" action="waitingreserves.pl" method="post"> >+ <input type="submit" /> >+ </form> >+ </div> >+ [% END %] >+ [% END %] > [% ELSE %] > <div id="resultlist" class="toptabs"> > <ul> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8448
:
10864
|
11045
|
11080