Attachment 110545 Details for Bug 22569 – Bug 22569: Refine GetTransfersFromTo to filter out unsent transfers

[patch] Bug 22569: Refine GetTransfersFromTo to filter out unsent transfers

Bug-22569-Refine-GetTransfersFromTo-to-filter-out-.patch (text/plain), 1.17 KB, created by Martin Renvoize (ashimema) on 2020-09-22 12:19:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-09-22 12:19:36 UTC

Size: 1.17 KB

patch

obsolete

>From 8b6d71cadc6e104d39292e90c2c5608f19700b53 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Fri, 20 Mar 2020 10:13:04 +0000
>Subject: [PATCH] Bug 22569: Refine GetTransfersFromTo to filter out unsent
> transfers
>
>GetTransfersFromTo is used solely by the transferstorecieve page which
>assumes items have already been sent. With the introduction of
>daterequested we allow for a state where a transfer has been scheduled
>but not yet sent (See stockrotation for such a case) and so we need to
>filter these transfers out from the transferstorecieve report.
>
>Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
>---
> C4/Circulation.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 0c3cd5f072..8fd60fccc3 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -3376,7 +3376,9 @@ sub GetTransfersFromTo {
>         FROM   branchtransfers
>         WHERE  frombranch=?
>           AND  tobranch=?
>+          AND datesent IS NOT NULL
>           AND datearrived IS NULL
>+          AND datecancelled IS NULL
>     ";
>     my $sth = $dbh->prepare($query);
>     $sth->execute( $frombranch, $tobranch );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22569: 90458 | 90477 | 90486 | 90487 | 94650 | 94651 | 94658 | 94659 | 96471 | 96472 | 96473 | 96474 | 96475 | 96478 | 96479 | 96516 | 96517 | 97392 | 97393 | 107258 | 107259 | 107260 | 107306 | 107307 | 107308 | 110284 | 110285 | 110286 | 110543 | 110544 | 110545 | 116572 | 116573 | 117612 | 117613 | 117840 | 117841 | 117842 | 117843 | 117847 | 117848 | 117878 | 117879 | 117880 | 117881