Attachment 110591 Details for Bug 23432 – Bug 23432: Replace 'die' with 'warn'

[patch] Bug 23432: Replace 'die' with 'warn'

Bug-23432-Replace-die-with-warn.patch (text/plain), 995 bytes, created by Martin Renvoize (ashimema) on 2020-09-23 11:29:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-09-23 11:29:53 UTC

Size: 995 bytes

patch

obsolete

>From 22e271a734adc3156ea0d7ce50853922fdb36fdb Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 23 Sep 2020 12:28:22 +0100
>Subject: [PATCH] Bug 23432: Replace 'die' with 'warn'
>
>This patch simply replaced the die statement with a warn such that the
>cron script may continue to rotate other items even if this item cannot
>be properly rotated due to corrupt data.
>---
> Koha/StockRotationItem.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/StockRotationItem.pm b/Koha/StockRotationItem.pm
>index b46dc3cc88..43d949acaa 100644
>--- a/Koha/StockRotationItem.pm
>+++ b/Koha/StockRotationItem.pm
>@@ -135,7 +135,7 @@ sub needs_advancing {
>             return 0;
>         }
>     } else {
>-        die "We have no historical branch transfer; this should not have happened!";
>+        warn "We have no historical branch transfer for itemnumber " . $self->itemnumber->itemnumber . "; This should not have happened!";
>     }
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 23432: 110591 | 112405 | 112424 | 112425