Attachment 110691 Details for Bug 26224 – Bug 26224: Prevent double submit of header check in form

[patch] Bug 26224: Prevent double submit of header check in form

Bug-26224-Prevent-double-submit-of-header-check-in.patch (text/plain), 2.17 KB, created by Katrin Fischer on 2020-09-24 18:45:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-09-24 18:45:26 UTC

Size: 2.17 KB

patch

obsolete

>From 6a7c6f3fa124124c780d5e0a00bcc413717605e9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 17 Aug 2020 10:16:14 +0000
>Subject: [PATCH] Bug 26224: Prevent double submit of header check in form
>
>To test:
> 1 - Browse to Home
> 1 - In the header bar select the 'Check in' tab
> 2 - Type a barcode into the box
> 3 - Hit Enter as many as times as you can
> 4 - Check the statistics table:
>    SELECT * FROM statistics WHERE itemnumber={itemnumber} AND DATE(datetime)=CURDATE();
> 5 - Note you have multiple lines for the same item at the same time
> 6 - Apply patch
> 7 - Reload the page
> 8 - Type the barcode
> 9 - Press Enter even more fast and more furiously
>10 - Check the statistics table
>11 - Only one entry, huzzah!
>
>Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>index 05681d3d8d..f05d09ea76 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js
>@@ -47,6 +47,8 @@ $.fn.selectTabByID = function (tabID) {
> 
>     $(".close").click(function(){ window.close(); });
> 
>+    $("#checkin_search form").preventDoubleFormSubmit();
>+
>     if($("#header_search #checkin_search").length > 0){ shortcut.add('Alt+r',function (){ $("#header_search").selectTabByID("#checkin_search"); $("#ret_barcode").focus(); }); } else { shortcut.add('Alt+r',function (){ location.href="/cgi-bin/koha/circ/returns.pl"; }); }
>     if($("#header_search #circ_search").length > 0){ shortcut.add('Alt+u',function (){ $("#header_search").selectTabByID("#circ_search"); $("#findborrower").focus(); }); } else { shortcut.add('Alt+u',function(){ location.href="/cgi-bin/koha/circ/circulation.pl"; }); }
>     if($("#header_search #catalog_search").length > 0){ shortcut.add('Alt+q',function (){ $("#header_search").selectTabByID("#catalog_search"); $("#search-form").focus(); }); } else { shortcut.add('Alt+q',function(){ location.href="/cgi-bin/koha/catalogue/search.pl"; }); }
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26224: 108390 | 110647 | 110691