Bugzilla – Attachment 110710 Details for
Bug 24780
952$i stocknumber does not display in batch item modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24780: Make items.stocknumber show up in batch item modification
Bug-24780-Make-itemsstocknumber-show-up-in-batch-i.patch (text/plain), 1.91 KB, created by
Katrin Fischer
on 2020-09-24 21:56:40 UTC
(
hide
)
Description:
Bug 24780: Make items.stocknumber show up in batch item modification
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2020-09-24 21:56:40 UTC
Size:
1.91 KB
patch
obsolete
>From 6c2fd51f7408228df28af9bfadada6a88e5f485b Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Thu, 24 Sep 2020 23:52:33 +0200 >Subject: [PATCH] Bug 24780: Make items.stocknumber show up in batch item > modification > >It looks like the field was intentionally removed from the list >of batch editable fields in the past. This makes sense as we >used to have a unique index on it at some point - but we do have >no more. > >This removes the exception so that the invendory number behaves >like the other fields on the batch item edit form. > >To test: >- Create some items with and without stocknumber >- Go to tools > batch item modification >- Enter the barcodes of your selected items in the list or > upload a file with them >- Verify that the stocknumber/inventory number is not showing > in the item edit form below >- Apply patch >- Reload the page - inventory number is there now >- Batch edit the inventory number and verify it works as expected >--- > tools/batchMod.pl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/tools/batchMod.pl b/tools/batchMod.pl >index 39df0f8f1d..443bc3b641 100755 >--- a/tools/batchMod.pl >+++ b/tools/batchMod.pl >@@ -430,9 +430,8 @@ foreach my $tag (sort keys %{$tagslib}) { > next if IsMarcStructureInternal( $tagslib->{$tag}{$subfield} ); > next if (not $allowAllSubfields and $restrictededition && !grep { $tag . '$' . $subfield eq $_ } @subfieldsToAllow ); > next if ($tagslib->{$tag}->{$subfield}->{'tab'} ne "10"); >- # barcode and stocknumber are not meant to be batch-modified >- next if $tagslib->{$tag}->{$subfield}->{'kohafield'} eq 'items.barcode'; >- next if $tagslib->{$tag}->{$subfield}->{'kohafield'} eq 'items.stocknumber'; >+ # barcode is not meant to be batch-modified >+ next if $tagslib->{$tag}->{$subfield}->{'kohafield'} eq 'items.barcode'; > my %subfield_data; > > my $index_subfield = int(rand(1000000)); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24780
:
110710
|
110711
|
110740