Attachment 11072 Details for Bug 7628 – [SIGNED-OFF] Bug 7628: Escape '+' characters for categorycode

[patch] [SIGNED-OFF] Bug 7628: Escape '+' characters for categorycode

SIGNED-OFF-Bug-7628-Escape--characters-for-categor.patch (text/plain), 2.36 KB, created by Marc Véron on 2012-07-23 09:09:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2012-07-23 09:09:38 UTC

Size: 2.36 KB

patch

obsolete

>From 1ffad2e9124f7c1b28a38f47d5a55667ce8bbd74 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Fri, 20 Jul 2012 10:48:27 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 7628: Escape '+' characters for categorycode
>Content-Type: text/plain; charset="utf-8"
>
>uri escape the following characters:
>    &, @, /, ;, :, =, +, ? and $
>
>Signed-off-by: Marc Veron <veron@veron.ch>
>
>Test and sign off second patch (independently from first patch).
>
>Added categories like '+zwoelf' or '? Test' before applying the patch.
>Deletion was not possible.
>
>After applying patch deletion is possible, patch works as expected.
>---
> .../prog/en/modules/admin/categorie.tt             |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>index e0be34b..711a223 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
>@@ -290,7 +290,7 @@ Confirm deletion of category [% categorycode |html %][% END %]</legend>
> 			<tr>
>                         <td>[% loo.categorycode |html %]</td>
>                         <td>
>-                            <a href="[% loo.script_name %]?op=add_form&amp;categorycode=[% loo.categorycode |url %]">[% loo.description |html %]</a>
>+                            <a href="[% loo.script_name %]?op=add_form&amp;categorycode=[% loo.categorycode |uri %]">[% loo.description |html %]</a>
>                         </td>
>                         <td>
>                             [% IF ( loo.type_A ) %]Adult[% END %]
>@@ -337,8 +337,8 @@ Confirm deletion of category [% categorycode |html %][% END %]</legend>
>                             [% END %]
>                         </td>
>                         [% END %]
>-                        <td><a href="[% loo.script_name %]?op=add_form&amp;categorycode=[% loo.categorycode |url %]">Edit</a></td>
>-						<td><a href="[% loo.script_name %]?op=delete_confirm&amp;categorycode=[% loo.categorycode |url %]">Delete</a></td>
>+                        <td><a href="[% loo.script_name %]?op=add_form&amp;categorycode=[% loo.categorycode |uri %]">Edit</a></td>
>+						<td><a href="[% loo.script_name %]?op=delete_confirm&amp;categorycode=[% loo.categorycode |uri %]">Delete</a></td>
> 		</tr>
> 		[% END %]
> 	</table>
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7628: 10918 | 10921 | 10922 | 10923 | 11034 | 11072