Attachment 110822 Details for Bug 26225 – Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js

[patch] Bug 26225: Move translatable strings out of audio_alerts.tt and into audio_alerts.js

Bug-26225-Move-translatable-strings-out-of-audioal.patch (text/plain), 3.92 KB, created by Katrin Fischer on 2020-09-27 11:24:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2020-09-27 11:24:19 UTC

Size: 3.92 KB

patch

obsolete

>From ba19764206defab1ae1eaddca30435f466cb18d7 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 17 Aug 2020 12:26:39 +0000
>Subject: [PATCH] Bug 26225: Move translatable strings out of audio_alerts.tt
> and into audio_alerts.js
>
>This patch removes the definition of translatable strings out of
>templates and into the corresponding JavaScript file, using the new JS
>i81n function.
>
>To test:
>
>- Apply the patch, go to Administration -> Audio alerts.
>- Click the "Delete selected alerts" button without checking any
>  checkboxes. You should see an error: "Check the box next to the alert
>  you want to delete."
>- Check the checkbox for an existing sound and click "Delete selected
>  alerts." You should get a confirmation message, "Are you sure you want
>  to delete the selected audio alerts?"
>- Click "New alert."
>- Without filling any details, click the "Play sound" button. You should
>  see an error message, "Please select or enter a sound."
>
>TESTING TRANSLATABILITY
>
>- Update a translation, e.g. fr-FR:
>
>> cd misc/translator
>> perl translate update fr-FR
>
>- Open the corresponding .po file for JavaScript strings, e.g.
>  misc/translator/po/fr-FR-messages-js.po
>- Locate strings pulled from
>  koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js for translation, e.g.:
>
>  msgid "Are you sure you want to delete the selected audio alerts?"
>  msgstr ""
>
>- Edit the "msgstr" string however you want (it's just for testing).
>- Install the updated translation:
>
>  > perl translate install fr-FR
>
>- Switch to your newly translated language in the staff client
>  and repeat the test plan above. The translated strings should
>  appear.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt | 5 -----
> koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js               | 8 +++++---
> 2 files changed, 5 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>index b88377ff1a..4587214c0e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/audio_alerts.tt
>@@ -137,11 +137,6 @@
>      </div> 
> [% MACRO jsinclude BLOCK %]
>     [% Asset.js("js/admin-menu.js") | $raw %]
>-    <script>
>-        var MSG_AUDIO_EMPTY_SOUND = _("Please select or enter a sound.");
>-        var MSG_AUDIO_CONFIRM_DELETE = _("Are you sure you want to delete the selected audio alerts?");
>-        var MSG_AUDIO_CHECK_CHECKBOXES = _("Check the box next to the alert you want to delete.")
>-    </script>
>     [% Asset.js("js/audio_alerts.js") | $raw %]
> [% END %]
> [% INCLUDE 'intranet-bottom.inc' %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js b/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js
>index 997c72a412..0fa22dc430 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/audio_alerts.js
>@@ -1,3 +1,5 @@
>+/* global __ */
>+
> $( document ).ready(function() {
>     var checkboxes = $("#delete-alert-form input[type='checkbox']");
>     var checkedcheckboxes = 0;
>@@ -37,7 +39,7 @@ $( document ).ready(function() {
>         if( soundfield.val() !== '' ){
>             playSound( soundfield.val() );
>         } else {
>-            alert( MSG_AUDIO_EMPTY_SOUND );
>+            alert( __("Please select or enter a sound.") );
>         }
>     });
> 
>@@ -59,9 +61,9 @@ $( document ).ready(function() {
> 
>     $('#delete-alert-form').on('submit', function() {
>         if( checkedcheckboxes == 1 ){
>-            return confirm( MSG_AUDIO_CONFIRM_DELETE );
>+            return confirm( __("Are you sure you want to delete the selected audio alerts?") );
>         } else {
>-            alert( MSG_AUDIO_CHECK_CHECKBOXES );
>+            alert( __("Check the box next to the alert you want to delete.") );
>             return false;
>         }
>     });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26225: 108394 | 110817 | 110822