Attachment 110842 Details for Bug 26152 – Bug 26152: Remove the use of jquery.checkboxes plugin from serial collection page

[patch] Bug 26152: Remove the use of jquery.checkboxes plugin from serial collection page

Bug-26152-Remove-the-use-of-jquerycheckboxes-plugi.patch (text/plain), 2.25 KB, created by David Nind on 2020-09-28 09:24:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-09-28 09:24:12 UTC

Size: 2.25 KB

patch

obsolete

>From 674b0b1209bba95b3fbf1a1a57b2c29188017277 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Wed, 5 Aug 2020 17:50:39 +0000
>Subject: [PATCH] Bug 26152: Remove the use of jquery.checkboxes plugin from
> serial collection page
>
>This patch removes the use of the jquery.checkboxes plugin from the
>serial collection page and replaces it with custom JS.
>
>To test, apply the patch and go to Serials.
>
>- Locate a subscription which has multiple issues.
>- View the details for that subscription.
>- In the sidebar menu click the "Serial collection" link.
>- On the serial collection page test the "Select all" and "Clear all"
>  links at the top of each table of issues. The controls should work
>  correctly and only affect the table on  that tab.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../intranet-tmpl/prog/en/modules/serials/serials-collection.tt      | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>index 3bd496be46..9c8b24b224 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
>@@ -310,7 +310,6 @@
>         var CONFIRM_DELETE_SUBSCRIPTION = _("Are you sure you want to delete this subscription?");
>     </script>
>     [% Asset.js("js/serials-toolbar.js") | $raw %]
>-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
> 
>     <script>
> 
>@@ -351,13 +350,13 @@
>             $(".CheckAll").on("click", function(e){
>                 e.preventDefault();
>                 var years = $(this).data("year");
>-                $("#subscription-year-" + years ).checkCheckboxes();
>+                $("#subscription-year-" + years + " input:checkbox").prop("checked", true );
>             });
> 
>             $(".CheckNone").on("click", function(e){
>                 e.preventDefault();
>                 var years = $(this).data("year");
>-                $("#subscription-year-" + years ).unCheckCheckboxes();
>+                $("#subscription-year-" + years + " input:checkbox").prop("checked", false );
>             });
> 
>             $(".generatenext").on("click", function(e){
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26152: 107856 | 110842 | 111445