Bugzilla – Attachment 110844 Details for
Bug 26351
Add plugin hooks to transform item barcodes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26351: Add unit tests
Bug-26351-Add-unit-tests.patch (text/plain), 2.27 KB, created by
Kyle M Hall (khall)
on 2020-09-28 10:51:42 UTC
(
hide
)
Description:
Bug 26351: Add unit tests
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-09-28 10:51:42 UTC
Size:
2.27 KB
patch
obsolete
>From 1799ebd592918408524a7f3ce814e3307e0b0b23 Mon Sep 17 00:00:00 2001 >From: John Doe <you@example.com> >Date: Fri, 25 Sep 2020 16:33:16 +0000 >Subject: [PATCH] Bug 26351: Add unit tests > >--- > t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t | 3 +++ > t/db_dependent/Koha/Plugins/Circulation_hooks.t | 1 + > t/lib/Koha/Plugin/Test.pm | 2 +- > 3 files changed, 5 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t >index 44f68ee87f..af49ef9563 100755 >--- a/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t >+++ b/t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t >@@ -52,6 +52,9 @@ subtest 'after_biblio_action() and after_item_action() hooks tests' => sub { > > my $plugin = Koha::Plugin::Test->new->enable; > >+ my $test_plugin = Test::MockModule->new('Koha::Plugin::Test'); >+ $test_plugin->mock( 'barcode_transform', undef ); >+ > my $biblio_id; > > warning_like { ( $biblio_id, undef ) = C4::Biblio::AddBiblio( MARC::Record->new(), '' ); } >diff --git a/t/db_dependent/Koha/Plugins/Circulation_hooks.t b/t/db_dependent/Koha/Plugins/Circulation_hooks.t >index 5f8569d9ed..c7ca3030bf 100755 >--- a/t/db_dependent/Koha/Plugins/Circulation_hooks.t >+++ b/t/db_dependent/Koha/Plugins/Circulation_hooks.t >@@ -66,6 +66,7 @@ subtest 'after_circ_action() hook tests' => sub { > my $test_plugin = Test::MockModule->new('Koha::Plugin::Test'); > $test_plugin->mock( 'after_item_action', undef ); > $test_plugin->mock( 'after_biblio_action', undef ); >+ $test_plugin->mock( 'barcode_transform', undef ); > > my $biblio = $builder->build_sample_biblio(); > my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ); >diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm >index a8cf2a5915..18767dc295 100644 >--- a/t/lib/Koha/Plugin/Test.pm >+++ b/t/lib/Koha/Plugin/Test.pm >@@ -95,7 +95,7 @@ sub intranet_js { > > sub barcode_transform { > my ( $self, $type, $barcode ) = @_; >- return "Koha::Plugin::Test::barcode_transform"; >+ Koha::Exceptions::Exception->throw("barcode_transform called with parameters: $type, $barcode"); > } > > sub barcode_generate { >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26351
:
109532
|
109548
|
109671
|
110844
|
110846
|
111575
|
111577
|
111578
|
111579
|
111862
|
111863
|
111894
|
111916
|
111917
|
111918
|
111919
|
111920
|
111921
|
111922
|
113571
|
113572
|
113573
|
113574
|
113575
|
113576
|
113577
|
113578
|
115172
|
115173
|
115174
|
115175
|
115176
|
115177
|
115178
|
115179
|
115180
|
118649
|
118650
|
118651
|
118652
|
118653
|
118654
|
118655
|
118656
|
118657
|
118658
|
118681
|
118682
|
118683
|
118684
|
118685
|
118686
|
118687
|
118688
|
118689
|
118690
|
122433
|
122434
|
122435
|
122436
|
122437
|
122438
|
122439
|
122440
|
122441
|
122442
|
124258
|
124259
|
124260
|
124261
|
124262
|
124263
|
124264
|
124265
|
124266
|
124313
|
125447
|
125763
|
125764
|
125765