Attachment 110875 Details for Bug 26145 – Bug 26145: (QA follow-up) Add missing filters

[patch] Bug 26145: (QA follow-up) Add missing filters

Bug-26145-QA-follow-up-Add-missing-filters.patch (text/plain), 2.79 KB, created by Jonathan Druart on 2020-09-28 15:03:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-09-28 15:03:50 UTC

Size: 2.79 KB

patch

obsolete

>From 8fa605111f3329ddceccad1a1bd590ad01f0266a Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Fri, 25 Sep 2020 19:05:02 +0000
>Subject: [PATCH] Bug 26145: (QA follow-up) Add missing filters
>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt     | 2 +-
> .../intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt      | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 63f9d43ac7..ceae99de20 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1270,7 +1270,7 @@ Note that permanent location is a code, and location may be an authval.
>         $(document).ready(function() {
>             var ids = ['holdings_table', 'otherholdings_table'];
>             var columns_settings = [ [% TablesSettings.GetColumns('catalogue', 'detail','holdings_table','json') | $raw %], [% TablesSettings.GetColumns('catalogue', 'detail','otherholdings_table','json')  | $raw %] ];
>-            var has_images = ["[% itemloop_has_images %]", "[% otheritemloop_has_images %]"];
>+            var has_images = ["[% itemloop_has_images | html %]", "[% otheritemloop_has_images | html %]"];
>             for (var i in ids) {
>                 var id = ids[i];
>                 if ( !has_images[i] ) { // remove the cover_image column
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>index 1e887ff9ad..5cbf01d51a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
>@@ -56,7 +56,7 @@
>             <div class="col-md-4">
>                 <ul class="thumbnails">
>                     [% FOREACH image IN images %]
>-                            <li id="imagenumber-[% image.imagenumber | html %]" data-itemnumber="[% image.itemnumber %]" data-biblionumber="[% image.biblionumber %]" class="thumbnail">
>+                            <li id="imagenumber-[% image.imagenumber | html %]" data-itemnumber="[% image.itemnumber | html %]" data-biblionumber="[% image.biblionumber | html %]" class="thumbnail">
>                             <a class="show_cover" data-coverimg="[% image.imagenumber | html %]" href="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=[% biblionumber | html %]&amp;imagenumber=[% image.imagenumber | html %]">
>                                 [% IF loop.first %]
>                                     <img class="selected" id="thumbnail_[% image.imagenumber | html %]" src="/cgi-bin/koha/catalogue/image.pl?imagenumber=[% image.imagenumber | html %]&amp;thumbnail=1" alt="Thumbnail" />
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26145: 109225 | 109226 | 110342 | 110343 | 110344 | 110345 | 110346 | 110347 | 110348 | 110349 | 110350 | 110351 | 110352 | 110353 | 110354 | 110675 | 110676 | 110677 | 110678 | 110679 | 110680 | 110681 | 110682 | 110683 | 110684 | 110685 | 110800 | 110861 | 110862 | 110863 | 110864 | 110865 | 110866 | 110867 | 110868 | 110869 | 110870 | 110871 | 110872 | 110873 | 110874 | 110875 | 111446 | 111447 | 111448 | 111449 | 111450 | 111451 | 111452 | 111453 | 111454 | 111455 | 111456 | 111457 | 111458