Bugzilla – Attachment 110951 Details for
Bug 12556
SelfCheck machine starts the hold instantly with an email sent out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12556: Reuse code from Koha::Hold instead of duplicating it
Bug-12556-Reuse-code-from-KohaHold-instead-of-dupl.patch (text/plain), 866 bytes, created by
Timothy Alexis Vass
on 2020-09-30 08:08:44 UTC
(
hide
)
Description:
Bug 12556: Reuse code from Koha::Hold instead of duplicating it
Filename:
MIME Type:
Creator:
Timothy Alexis Vass
Created:
2020-09-30 08:08:44 UTC
Size:
866 bytes
patch
obsolete
>From 1f7852fe15dfe58671a550c7af591ec8098f84e5 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi> >Date: Wed, 22 Jul 2020 15:44:31 +0000 >Subject: [PATCH] Bug 12556: Reuse code from Koha::Hold instead of duplicating > it > >Signed-off-by: John Doe <you@example.com> >--- > C4/Reserves.pm | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 4690d97faf..322002d66f 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -567,10 +567,7 @@ sub CanReserveBeCanceledFromOpac { > my $reserve = Koha::Holds->find($reserve_id); > > return 0 unless $reserve->borrowernumber == $borrowernumber; >- return 0 if ( $reserve->found eq 'W' ) or ( $reserve->found eq 'T' ); >- >- return 1; >- >+ return $reserve->is_cancelable_from_opac; > } > > =head2 GetOtherReserves >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=110951">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12556
:
107181
|
107182
|
107183
|
107184
|
107185
|
107186
|
108711
|
109140
|
109924
|
109925
|
109926
|
109927
|
109928
|
109929
|
110719
|
110942
|
110943
|
110944
|
110945
|
110946
|
110947
|
110948
|
110949
|
110950
|
110951
|
110952
|
110953
|
110954
|
110955
|
110956
|
110961
|
110962
|
110963
|
110964
|
110965
|
110966
|
111405
|
111406
|
111407
|
111408
|
111409
|
111410
|
111494
|
111495
|
111496
|
111497
|
111498
|
111499
|
111500
|
111509
|
111516
|
111585
|
111610