Attachment 111027 Details for Bug 25261 – Bug 25261: Prevent tests to fail if CircConfirmItemParts is on

[patch] Bug 25261: Prevent tests to fail if CircConfirmItemParts is on

Bug-25261-Prevent-tests-to-fail-if-CircConfirmItem.patch (text/plain), 1.71 KB, created by Jonathan Druart on 2020-10-01 09:40:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-10-01 09:40:18 UTC

Size: 1.71 KB

patch

obsolete

>From 14d8778cfc05ecaa767d89d55f9726147513b4db Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 1 Oct 2020 11:35:00 +0200
>Subject: [PATCH] Bug 25261: Prevent tests to fail if CircConfirmItemParts is
> on
>
>Setting items.materials to NULL at TestBuilder level will (certainly) prevent some
>tests to fail if the pref is on
>
>In t/db_dependent/selenium/basic_workflow.t we set 952$3 to an empty
>string. The tests will pass even if the pref is turned on.
>---
> t/db_dependent/selenium/basic_workflow.t | 5 +++++
> t/lib/TestBuilder.pm                     | 1 +
> 2 files changed, 6 insertions(+)
>
>diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t
>index a988bb8683..c4bb0310c5 100755
>--- a/t/db_dependent/selenium/basic_workflow.t
>+++ b/t/db_dependent/selenium/basic_workflow.t
>@@ -208,6 +208,11 @@ SKIP: {
>             ) {
>                 $v = ""; # The input has been prefilled with %Y-%m-%d already
>             }
>+            elsif (
>+                $id =~ m|^tag_952_subfield_3| # materials
>+            ) {
>+                $v = ""; # We don't want the checkin/checkout to need confirmation if CircConfirmItemParts is on
>+            }
>             else {
>                 $v = 't_value_bib' . $biblionumber;
>             }
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index c40f6e6149..26de949fb3 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -552,6 +552,7 @@ sub _gen_default_values {
>             withdrawn          => 0,
>             restricted         => 0,
>             damaged            => 0,
>+            materials          => undef,
>             more_subfields_xml => undef,
>         },
>         Category => {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25261: 103856 | 103857 | 104011 | 104012 | 104013 | 104404 | 104405 | 104406 | 104407 | 104408 | 104409 | 104410 | 104411 | 104412 | 104413 | 104414 | 107217 | 107218 | 107219 | 107220 | 107221 | 107222 | 107228 | 107229 | 107230 | 107231 | 107232 | 107233 | 107234 | 107285 | 107331 | 107822 | 107823 | 108196 | 108197 | 108198 | 108199 | 108200 | 108201 | 108202 | 108203 | 108204 | 108205 | 108206 | 108207 | 108208 | 108230 | 108231 | 108232 | 108233 | 108234 | 108235 | 108236 | 108237 | 108238 | 108239 | 108240 | 108241 | 108242 | 109478 | 109479 | 109480 | 109481 | 109482 | 109483 | 109484 | 109485 | 109486 | 109487 | 109488 | 109489 | 109490 | 109491 | 109492 | 109493 | 109494 | 109495 | 109496 | 109497 | 109498 | 109499 | 109500 | 109501 | 109502 | 109503 | 109504 | 109508 | 110038 | 110039 | 110040 | 110041 | 110042 | 110043 | 110044 | 110045 | 110046 | 110047 | 110048 | 110049 | 110050 | 110051 | 110052 | 110133 | 110184 | 110258 | 110259 | 110268 | 110322 | 110323 | 110324 | 110325 | 110326 | 110327 | 110328 | 110329 | 110330 | 110331 | 110332 | 110333 | 110334 | 110335 | 110336 | 110337 | 110338 | 110339 | 110340 | 110341 | 110356 | 110357 | 110358 | 110359 | 110360 | 110361 | 110362 | 110363 | 110364 | 110365 | 110366 | 110367 | 110368 | 110369 | 110370 | 110371 | 110372 | 110373 | 110374 | 110375 | 110915 | 110916 | 110917 | 110918 | 110919 | 110920 | 110921 | 110922 | 110923 | 110924 | 110925 | 110926 | 110927 | 110928 | 110929 | 110930 | 110931 | 110932 | 110933 | 110934 | 111027